Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: Bump grpc_health_probe to v0.4.24 #30643

Merged
merged 1 commit into from Feb 11, 2024
Merged

dep: Bump grpc_health_probe to v0.4.24 #30643

merged 1 commit into from Feb 11, 2024

Conversation

ferozsalam
Copy link
Contributor

Contains updated deps that clear up some CVEs.

@ferozsalam ferozsalam added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels Feb 6, 2024
@ferozsalam ferozsalam requested a review from a team as a code owner February 6, 2024 11:27
@ferozsalam ferozsalam added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Feb 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.1 Feb 6, 2024
@sayboras
Copy link
Member

sayboras commented Feb 6, 2024

/test

sayboras
sayboras approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, I came across similar update in envoy repo.

chancez
chancez requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@chancez chancez left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the renovate comment be updated as well? Also, why has renovate tried to update this if there's been multiple releases since it's been added?

images/hubble-relay/download-grpc-health-probe.sh Outdated Show resolved Hide resolved
@ferozsalam
Bump grpc_health_probe
c2e3f58 
Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
@ferozsalam ferozsalam force-pushed the pr/feroz/bump-grpc-health-probe branch from 6cc4899 to c2e3f58 Compare February 7, 2024 07:00
@ferozsalam
Copy link
Contributor Author

Should the renovate comment be updated as well? Also, why has renovate tried to update this if there's been multiple releases since it's been added?

I've updated the Renovate comment and pinged @glrf yesterday to review the Renovate behaviour so that we don't have to do this manually in the future – I am also not sure why Renovate isn't picking the updates up automatically.

@glrf
Copy link
Contributor

glrf commented Feb 7, 2024

I think the reason why renovate wasn't picking it up was because I forgot to add a file match here: https://github.com/cilium/cilium/blob/main/.github/renovate.json5#L499-L501 (sorry about that 😅 )

@ferozsalam
Copy link
Contributor Author

/test

glrf added a commit to glrf/cilium that referenced this pull request Feb 8, 2024
@glrf
Fix renovate config for grpc_health_probe
cde1347 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.
glrf added a commit to glrf/cilium that referenced this pull request Feb 8, 2024
@glrf
Fix renovate config for grpc_health_probe
4858be2 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf mentioned this pull request Feb 8, 2024
Merged
2 tasks
glrf added a commit to glrf/cilium that referenced this pull request Feb 8, 2024
@glrf
Fix renovate config for grpc_health_probe
7b40d36 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/cilium that referenced this pull request Feb 8, 2024
@glrf
Fix renovate config for grpc_health_probe
9023142 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@sayboras sayboras changed the title Bump grpc_health_probe dep: Bump grpc_health_probe to v0.4.24 Feb 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 11, 2024
@sayboras sayboras added this pull request to the merge queue Feb 11, 2024
Merged via the queue into main with commit 5822544 Feb 11, 2024
218 of 220 checks passed
@sayboras sayboras deleted the pr/feroz/bump-grpc-health-probe branch February 11, 2024 03:07
@sayboras sayboras mentioned this pull request Feb 11, 2024
Merged
2 tasks
@sayboras sayboras added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.1 Feb 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2024
@glrf @sayboras
Fix renovate config for grpc_health_probe
d4a57d8 
In #30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.1 Feb 12, 2024
janvi01 pushed a commit to janvi01/cilium that referenced this pull request Feb 12, 2024
@glrf @janvi01
fix: squash commits
8da7dc1 
Fix renovate config for grpc_health_probe

In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>

fix: require changes

Signed-off-by: janvi01 <janvibajo1@gmail.com>
dlapcevic pushed a commit to dlapcevic/cilium that referenced this pull request Feb 13, 2024
@glrf @dlapcevic
Fix renovate config for grpc_health_probe
7cc4183 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
Pionerd pushed a commit to Pionerd/cilium that referenced this pull request Feb 13, 2024
@glrf @Pionerd
Fix renovate config for grpc_health_probe
fd02f9d 
In cilium#30643 we noticed that we forgot to add a file match so renovate did
not update the dependency. This PR should fix that and renovate should
start updating the dependency automatically.

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@michi-covalent michi-covalent mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@chancez chancez chancez approved these changes

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ferozsalam @sayboras @glrf @rolinh @chancez @aanm