node_addressing: fix edge case where getDirectRouting returns nil
#30757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
release-note/bug
borkmann
approved these changes
Feb 14, 2024
|
/test |
If we construct a `nodeAddressing` object with the IPv4 flag, and then call `getDirectRouting` while the directRoutingDevice doesn't contain an IPv4 address, it would return a nil address instead of the failure condition. This can cause a panic in the caller who assumes that the IP is never nil. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/fix-addressfamily-directrouting
branch
from
16be223
to
ee484a5
Compare
|
/test |
5 tasks
michi-covalent
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.1
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.1
github-actions
bot
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we construct a
nodeAddressingobject with the IPv4 flag, and then callgetDirectRoutingwhile the directRoutingDevice doesn't contain an IPv4 address, it would return a nil address instead of the error condition. This can cause a panic in the caller who assumes that the IP is never nil.Fixes: #30746