v1.15 backports 2024-02-14 #30767
Merged
v1.15 backports 2024-02-14 #30767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit c19a84e ] This error can happen if a state is being destroyed while packets are in flight. It should be rare as the window in the kernel where it can happen is very short. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit 51b4308 ] Moved BGP rest APIs from daemon package to bgpv2 sub-system. This allows us to remove references of BGP control plane from daemon. Signed-off-by: harsimran pabla <hpabla@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit 3c479d4 ] The test output are riddled with logs such as: Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init), install-cni-binaries (init) This gets particularly noisy when waiting for the key rotation to complete, during which time we run kubectl exec repeatedly. This commit fixes it. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit afb3eb6 ] If we construct a `nodeAddressing` object with the IPv4 flag, and then call `getDirectRouting` while the directRoutingDevice doesn't contain an IPv4 address, it would return a nil address instead of the failure condition. This can cause a panic in the caller who assumes that the IP is never nil. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit b8f6976 ] Issue cilium#30563 showed that veth devices were picked as selected native devices even though they did not have a route. This was due to a bug in the route StateDB table indexing. This commit expands the devices controller tests to catch this wrong behavior. Signed-off-by: Jussi Maki <jussi@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit 0844200 ] The RouteID.Key() was supposed to make a composite key from 'table + index + destination', but due to a copy-paste brainfart the composite index was 'table + table + destination'. Fix Key() to correctly build the key. While at it, make it more efficient by pre-allocating the correct fixed-size byte slice. Fixes: cilium#30563 Fixes: 8abf620 ("devices_controller: Switched devices and routes from StateDB to StateDB2") Signed-off-by: Jussi Maki <jussi@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit 0e67360 ] We are failing a e2e test quite consistantly, while the root cause is not fully clear, it seems that setting devices explicitly might help. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added
kind/backports
michi-covalent
requested review from
brlbil,
dylandreimerink,
harsimran-pabla and
pchaigno
|
/test-backport1.15 |
|
/test-backport-1.15 |
joestringer
approved these changes
Feb 14, 2024
|
running ci-e2e in #30771 |
Closed
|
✅ ran ci-e2e from a non-fork PR to test the workflow file change: https://github.com/cilium/cilium/actions/runs/7907721456. time to 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDirectRoutingreturns nil #30757 -- node_addressing: fix edge case wheregetDirectRoutingreturns nil (@dylandreimerink)Once this PR is merged, a GitHub action will update the labels of these PRs: