hubble: fix parsing of invalid HTTP URLs #31100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e redact test functions Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch, Hubble could cause a Cilium agent panic when attempting to decode invalid URLs. See cilium#31071 Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch, Hubble would panic when attempting to parse a accesslog.LogRecordHTTP with a nil URL. While filterURL was handling the nil case, the following caller codepath would unconditionally call String() on the URL, potentially causing a panic. This patch improves Hubble robustness and clarify the role of the filterURL (renamed filteredURL) to always return an URL such as calling String() on it is safe. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added
kind/bug
chancez
approved these changes
Mar 1, 2024
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
pippolo84
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31071, easier to review commit by commit as there is a couple of cosmetic renaming / moving commits.
Selecting for
v1.15backport as the original report was based onv1.15.1.v1.14is unaffected because we're checking fornil, andv1.13didn't attempt to clone the accesslog URL before mutating it.