New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: devices: increase priority of user choice #31200
Merged
joamaki
merged 1 commit into
cilium:main
from
bimmlerd:pr/bimmlerd/prioritize-user-device-selection
Mar 6, 2024
Merged
linux: devices: increase priority of user choice #31200
joamaki
merged 1 commit into
cilium:main
from
bimmlerd:pr/bimmlerd/prioritize-user-device-selection
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devices controller contains the logic to determine which devices are considered "selected" - that is, which devices cilium considers for things like the choice of direct routing device, etc. As part of this logic, we look at the user-provided configuration, in the form of the '--devices' flag. However, existing code is slightly too opinionated in that it excludes the loopback device before it looks at what the user specifies. It has been reported that using the loopback interface lo as the direct routing device worked in 1.14, but no longer does in 1.15. As this is a somewhat unusual setup, we require the user to specifically include 'lo' into the devices and respect their choice in the selection logic. Fixes: 03ad61b (datapath/linux: Implement DevicesController) Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 6, 2024
bimmlerd
added
area/daemon
Impacts operation of the Cilium daemon.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/agent
Cilium agent related.
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
and removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Mar 6, 2024
/test |
CI triage (WIP):
|
joamaki
approved these changes
Mar 6, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 6, 2024
1 task
bimmlerd
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Mar 6, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.2
Mar 6, 2024
github-actions
bot
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Mar 7, 2024
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in 1.15.2
Mar 7, 2024
2 tasks
robertvolkmann
added a commit
to metal-stack/gardener-extension-networking-cilium
that referenced
this pull request
May 8, 2024
robertvolkmann
added a commit
to metal-stack/gardener-extension-networking-cilium
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/daemon
Impacts operation of the Cilium daemon.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/agent
Cilium agent related.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devices controller contains the logic to determine which devices are considered "selected" - that is, which devices cilium considers for things like the choice of direct routing device, etc.
As part of this logic, we look at the user-provided configuration, in the form of the '--devices' flag. However, existing code is slightly too opinionated in that it excludes the loopback device before it looks at what the user specifies. It has been reported that using the loopback interface lo as the direct routing device worked in 1.14, but no longer does in 1.15. As this is a somewhat unusual setup, we require the user to specifically include 'lo' into the devices and respect their choice in the selection logic.
Fixes: 03ad61b (datapath/linux: Implement DevicesController)
Fixes: #30889