[v1.15] Backport of #31200 - linux device user choice prioritization #31206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 2b51393 ] The devices controller contains the logic to determine which devices are considered "selected" - that is, which devices cilium considers for things like the choice of direct routing device, etc. As part of this logic, we look at the user-provided configuration, in the form of the '--devices' flag. However, existing code is slightly too opinionated in that it excludes the loopback device before it looks at what the user specifies. It has been reported that using the loopback interface lo as the direct routing device worked in 1.14, but no longer does in 1.15. As this is a somewhat unusual setup, we require the user to specifically include 'lo' into the devices and respect their choice in the selection logic. Fixes: 03ad61b (datapath/linux: Implement DevicesController) Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
added
kind/backports
bimmlerd
changed the title
3 tasks
|
/test-backport-1.15 |
joestringer
approved these changes
Mar 6, 2024
|
CI triage (WIP): |
|
CI is green, review is good - marking ready-to-merge as MLH isn't 😢 |
bimmlerd
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: