Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Values: preflight.nodeSelector Does Not Render Correctly #32497

Closed
3 tasks done
littlesheng19 opened this issue May 13, 2024 · 2 comments · Fixed by #32548
Closed
3 tasks done

Helm Values: preflight.nodeSelector Does Not Render Correctly #32497

littlesheng19 opened this issue May 13, 2024 · 2 comments · Fixed by #32548
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/agent Cilium agent related.

Comments

@littlesheng19
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

"preflight.nodeSelector" does not seem to work, as it appears to be not addressed in the Helm template.

https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/templates/cilium-preflight/daemonset.yaml#L30

For example:

$ cat preflight.yaml

operator:
  enabled: false
agent: false
preflight:
  enabled: true
  nodeSelector:
    cnitype: cilium
  tolerations:
  - operator: Exist

And nodeSelector shows <none> as it does not render nodeSelector correctly in daemonset:

k get ds -n cilium 
NAME                      DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR                           AGE
cilium                    52        52        52      52           52          cnitype=cilium,kubernetes.io/os=linux   312d
cilium-pre-flight-check   54        54        52      24           52          <none>                                  49m

Cilium Version

1.15.4

Kernel Version

Linux ip-172-30-236-195.ap-southeast-1.compute.internal 5.10.215-203.850.amzn2.x86_64 #1 SMP Tue Apr 23 20:32:19 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Kubernetes Version

1.26

Regression

No response

Sysdump

No response

Relevant log output

No response

Anything else?

No response

Cilium Users Document

  • Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

  • I agree to follow this project's Code of Conduct
@littlesheng19 littlesheng19 added kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. needs/triage This issue requires triaging to establish severity and next steps. labels May 13, 2024
@squeed
Copy link
Contributor

squeed commented May 15, 2024

whoops!

@squeed squeed added area/helm Impacts helm charts and user deployment experience and removed needs/triage This issue requires triaging to establish severity and next steps. labels May 15, 2024
squeed added a commit to squeed/cilium that referenced this issue May 15, 2024
@squeed
helm: add nodeSelector to preflight DaemonSet
cda96ac 
We had the value, but forgot to plumb it in.

Fixes: cilium#32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed mentioned this issue May 15, 2024
Merged
@squeed
Copy link
Contributor

squeed commented May 15, 2024

Filed a quick PR to fix this; good spot!

@squeed squeed added the sig/agent Cilium agent related. label May 16, 2024
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@squeed
helm: add nodeSelector to preflight DaemonSet
a1e5295 
We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 23, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
bbbb8b0 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
15a24cf 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
fdee4df 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
960ba32 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
cb2284f 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
d643398 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
9927c1f 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
6da2e12 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 24, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
9d27190 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 25, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
24a3190 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 25, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
8c1394d 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 27, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
077ccc9 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
aanm pushed a commit that referenced this issue May 27, 2024
@squeed @aanm
helm: add nodeSelector to preflight DaemonSet
e4d1bff 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa pushed a commit that referenced this issue May 28, 2024
@squeed @YutaroHayakawa
helm: add nodeSelector to preflight DaemonSet
6c8113e 
[ upstream commit a1e5295 ]

We had the value, but forgot to plumb it in.

Fixes: #32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. sig/agent Cilium agent related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: add nodeSelector to preflight DaemonSet squeed/cilium
2 participants
@squeed @littlesheng19