Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for supplying basic authentication credentials #1002

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Apr 26, 2023

Use case: I want to configure my ingress controller to expose hubble relay with basic auth, but Hubble CLI cannot pass basic auth credentials through.

@chancez chancez added the 🌟 kind/feature This introduces new functionality. label Apr 26, 2023
@chancez chancez requested a review from a team as a code owner April 26, 2023 22:52
@chancez chancez self-assigned this Apr 26, 2023
@chancez chancez requested review from kaworu and removed request for a team April 26, 2023 22:52
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label PR is blocked until the release note is set labels Apr 26, 2023
@chancez chancez added the release-note/major This PR introduces major new functionality to Hubble. label Apr 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 27, 2023
@chancez chancez force-pushed the pr/chancez/basic_auth branch 2 times, most recently from 2b40546 to 67752a4 Compare April 27, 2023 15:44
cmd/common/config/flags.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Apr 28, 2023
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez merged commit e63885c into master Apr 28, 2023
5 checks passed
@chancez chancez deleted the pr/chancez/basic_auth branch April 28, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants