Configure Renovate #1011

renovate · 2023-05-04T01:08:46Z

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

Dockerfile (dockerfile)
.github/workflows/build-images-release.yaml (github-actions)
.github/workflows/codeql-analysis.yml (github-actions)
.github/workflows/integration-tests.yaml (github-actions)
.github/workflows/release.yml (github-actions)
.github/workflows/tests.yml (github-actions)
go.mod (gomod)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

You have configured Renovate to use the following baseBranches: master, v0.11.

What to Expect

With your current configuration, Renovate will create 4 Pull Requests:

fix(deps): pin dependencies (master)

Schedule: ["at any time"]
Branch name: renovate/master-all-go-deps-master
Merge into: master
Upgrade github.com/fatih/color to 12126ed593697635c525b302836b292b657ea573
Upgrade github.com/google/go-cmp to a97318bf6562f2ed2632c5f985db51b1bc5bdcd0
Upgrade github.com/sirupsen/logrus to f8bf7650dccb756cea26edaf9217aab85500fe07
Upgrade github.com/spf13/cast to 2b0eb0f724e320b655240e331aef36d1175986c2
Upgrade github.com/spf13/cobra to 4dd4b25de38418174a6e859e8a32eaccca32dccc
Upgrade github.com/spf13/pflag to 2e9d26c8c37aae03e3f9d4e90b7116f5accb7cab
Upgrade github.com/spf13/viper to 518241257478c557633ab36e474dfcaeb9a3c623
Upgrade github.com/stretchr/testify to f36bfe3c337aa95c86f04c721acdbafb5ffb1611
Upgrade golang.org/x/sys to ca59edaa5a761e1d0ea91d6c07b063f85ef24f78
Upgrade google.golang.org/grpc to deeee5cf87c57e7f205795f0d88290f862855c47
Upgrade google.golang.org/protobuf to f221882bfb484564f1714ae05f197dea2c76898d
Upgrade gopkg.in/yaml.v2 to f6f7691b1fdeb513f56608cd2c32c51f8194bf51

chore(deps): update all github action dependencies (master)

Schedule: ["at any time"]
Branch name: renovate/master-all-github-action
Merge into: master
Upgrade actions/checkout to f095bcc56b7c2baf48f3ac70d6d6782f4f553222
Upgrade actions/create-release to 4c11c9fe1dcd9636620a16455165783b20fc7ea0
Upgrade actions/download-artifact to e9ef242655d12993efdcda9058dee2db83a2cb9b
Upgrade actions/setup-go to fac708d6674e30b6ba41289acaab6d4b75aa0753
Upgrade actions/upload-artifact to 65d862660abb392b8c4a3d1195a2108db131dd05
Upgrade azure/setup-helm to ac5ee1fca8fba06d82bfc39af726f19ffe037a49
Upgrade docker/build-push-action to eafaea8d0f5853934deece2ffa67af59d936562b
Upgrade docker/login-action to 40891eba8c2bcd1309b07ba8b11232f313e86779
Upgrade docker/setup-buildx-action to a946f06b5ddbde456d0115dc585e8dc3c7a0c3e0
Upgrade github/codeql-action to 95cfca769b334017179a1fbe879b6d9b5cddfe54
Upgrade golangci/golangci-lint-action to 0d51521d4226fe362fc8aa8ce484ce3cd5299478
Upgrade helm/kind-action to 2d96ac1d715d2ea5abee55927b0cce7ec07ca148
Upgrade skx/github-action-publish-binaries to 44887b225ceca96efd8a912d39c09ad70312af31

fix(deps): update module gopkg.in/yaml.v2 to v3 (master)

Schedule: ["at any time"]
Branch name: renovate/master-major-3-all-go-deps-master
Merge into: master
Upgrade gopkg.in/yaml.v2 to f6f7691b1fdeb513f56608cd2c32c51f8194bf51

chore(deps): update all github action dependencies (v0.11)

Schedule: ["at any time"]
Branch name: renovate/v0.11-all-github-action
Merge into: v0.11
Upgrade actions/checkout to f095bcc56b7c2baf48f3ac70d6d6782f4f553222
Upgrade actions/create-release to 4c11c9fe1dcd9636620a16455165783b20fc7ea0
Upgrade actions/download-artifact to e9ef242655d12993efdcda9058dee2db83a2cb9b
Upgrade actions/setup-go to fac708d6674e30b6ba41289acaab6d4b75aa0753
Upgrade actions/upload-artifact to 65d862660abb392b8c4a3d1195a2108db131dd05
Upgrade docker/build-push-action to eafaea8d0f5853934deece2ffa67af59d936562b
Upgrade docker/login-action to 40891eba8c2bcd1309b07ba8b11232f313e86779
Upgrade docker/setup-buildx-action to a946f06b5ddbde456d0115dc585e8dc3c7a0c3e0
Upgrade github/codeql-action to 95cfca769b334017179a1fbe879b6d9b5cddfe54
Upgrade golangci/golangci-lint-action to 0d51521d4226fe362fc8aa8ce484ce3cd5299478
Upgrade skx/github-action-publish-binaries to 44887b225ceca96efd8a912d39c09ad70312af31

🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for prhourlylimit for details.

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Mend Renovate. View repository job log here.

gandro

Looks good overall. One question around one of the regex patterns (the other one looks good to me!)

gandro · 2023-05-08T08:36:23Z

renovate.json5

+      // similar to the examples shown here:
+      //   https://docs.renovatebot.com/modules/manager/regex/#advanced-capture
+      "matchStrings": [
+        "# renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)\\s+.+version: (?<currentValue>.*)"


@chancez Have you tested this by running Renovate locally? The currentValue capture here seems to include the ' quotes and I'm not sure if Renovate will properly parse them:

https://regex101.com/r/4EqOrE/1

I haven't, I haven't had much success getting it running locally. Getting all the deps locally has been a struggle, and the docker image is x86 only and too slow if emulated. I copied 99.9% of the setup from cilium though, so if this is wrong, it's broken in cilium too. I'll try taking another stab at running it locally.

Ah we don't use quotes in cilium's CI for go-version. That's the difference.

Okay, new commit will update the regex. Here's what I've got instead, which should handle quotes and no-quotes:

https://regex101.com/r/HYe6SP/1

Added a couple of cases at https://regex101.com/r/oErr7U/3

Oh man the escaping for this is painful, I miss YAML (words I usually never say).

kaworu

Thanks @chancez! Some questions / comments

renovate.json5

chancez · 2023-05-08T19:57:14Z

@gandro @kaworu I've pushed some new commits, please take a look.

chancez · 2023-05-08T20:59:09Z

Alright I've figured out running renovate. Currently practicing on my fork https://github.com/chancez/hubble. You may notice unexpected PRs as I'm going to revert some recent ones in my fork so I can test how it handles updates for things that are already up to date.

kaworu

Thanks @chancez, LGTM now!

kaworu · 2023-05-09T07:15:21Z

RELEASE.md

@@ -145,6 +145,16 @@ After a new stable `v$MAJOR.$MINOR` release branch has been created, update the
 `target-branch` and `commit-message.prefix` fields in `.github/dependabot.yml`
 to point to the newly created branch, instead of the old stable branch.

+## Update the `renovate` configuration
+
+After a new stable `v$MAJOR.$MINOR` release branch has been created, update `renovate.json5`:


Any reason we're keeping renovate.json5 at the root of the project instead of .github/renovate.json5 like we have at cilium/cilium?

The original PR put it at renovate.json at the root, but your right, I can move it into .github I think.

renovate.json5

gandro

Thanks!

RELEASE.md

chancez · 2023-05-09T23:22:03Z

Okay I've pushed another commit with the latest changes I'm thinking about after iterating in my fork.

I want to remove the schedule initially so we can iterate a bit easier and so that it will open the PRs immediately so we can resolve them after the PR is merged. Once things are settled a bit we can add the schedules back.
I made it so it will update both the Dockerfile Go versions and the GHA go-version in the same PR.

Take a look at my fork to see what it would look like with some outdated dependencies. I reverted and changed the versions in my master branch to make it easier to test, not all these PRs will need to be opened once this PR is merged. https://github.com/chancez/hubble/pulls

kaworu · 2023-05-10T13:47:49Z

.github/renovate.json5

+      "groupName": "golang-stable",
+      // Restrict the alpine version that can be used on stable branches
      "matchPackageNames": [
        "docker.io/library/alpine"
      ],


group named golang-stable for the alpine image? 🤔

Yes, it's part of the Golang image updates. I suppose this made more sense when the group name was Golang-images but I changed it to Golang and now it's less apt.

This is the same as cilium, it's just less obvious with the inheritance, hence explicitly adding the groupName. Now I question if this should be part of that group or if I should rename the group.

The group name mostly changes the branch/PR name and is how the PRs get grouped together. Do we want a separate PR for alpine updates? That would seem reasonable to me.

kaworu · 2023-05-10T13:52:36Z

Thanks for the update @chancez, LGTM beside my comment about golang/alpine.

I want to remove the schedule initially so we can iterate a bit easier

nitpicking: instead of removing, we could comment them (json5 ftw) so that we're less likely to forget to get them back at some point?

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>

chancez · 2023-05-10T15:22:09Z

@kaworu if you want to make one final pass I can get this merged today/tomorrow and we can work on merging renovate PRs/disabling dependabot if all goes well.

renovate bot requested a review from a team as a code owner May 4, 2023 01:08

renovate bot requested review from chancez and removed request for a team May 4, 2023 01:08

maintainer-s-little-helper bot added dont-merge/needs-sign-off dont-merge/needs-release-note-label PR is blocked until the release note is set labels May 4, 2023

chancez requested review from a team as code owners May 4, 2023 21:54

chancez requested review from brlbil and removed request for a team May 4, 2023 21:54

chancez force-pushed the renovate/configure branch 2 times, most recently from 6074fce to c19bdde Compare May 4, 2023 21:56

cilium deleted a comment from maintainer-s-little-helper bot May 4, 2023

chancez force-pushed the renovate/configure branch from c19bdde to 572527e Compare May 4, 2023 21:59

maintainer-s-little-helper bot removed the dont-merge/needs-sign-off label May 4, 2023

chancez force-pushed the renovate/configure branch from 572527e to 1df6ba0 Compare May 4, 2023 22:09

brlbil approved these changes May 5, 2023

View reviewed changes

chancez requested review from a team and gandro and removed request for a team May 5, 2023 14:58

chancez self-assigned this May 5, 2023

gandro reviewed May 8, 2023

View reviewed changes

gandro added the release-note/ci This PR makes changes to the CI. label May 8, 2023

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label May 8, 2023

kaworu requested changes May 8, 2023

View reviewed changes

renovate.json5 Outdated Show resolved Hide resolved

renovate.json5 Outdated Show resolved Hide resolved

renovate.json5 Outdated Show resolved Hide resolved

renovate.json5 Outdated Show resolved Hide resolved

renovate.json5 Outdated Show resolved Hide resolved

chancez added the needs-rebase This PR needs to be rebased because it has merge conflicts. label May 8, 2023

maintainer-s-little-helper bot requested a review from kaworu May 8, 2023 17:04

kaworu approved these changes May 9, 2023

View reviewed changes

gandro approved these changes May 9, 2023

View reviewed changes

RELEASE.md Outdated Show resolved Hide resolved

RELEASE.md Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

kaworu reviewed May 10, 2023

View reviewed changes

chancez force-pushed the renovate/configure branch from 66c54f0 to 67aca4e Compare May 10, 2023 15:16

Configure renovate

d5e1acb

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>

chancez force-pushed the renovate/configure branch from 67aca4e to d5e1acb Compare May 10, 2023 15:18

chancez approved these changes May 10, 2023

View reviewed changes

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 10, 2023

chancez merged commit 788b5df into master May 10, 2023
5 checks passed

chancez deleted the renovate/configure branch May 10, 2023 18:39

This was referenced May 10, 2023

Configure hubble CI to use renovate for Go updates #1009

Closed

Add example links to renovate configuration in RELEASE.md #1030

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure Renovate #1011

Configure Renovate #1011

renovate bot commented May 4, 2023 •

edited

gandro left a comment

gandro May 8, 2023

chancez May 8, 2023 •

edited

chancez May 8, 2023

chancez May 8, 2023

kaworu May 9, 2023

chancez May 9, 2023

kaworu left a comment

chancez commented May 8, 2023

chancez commented May 8, 2023 •

edited

kaworu left a comment

kaworu May 9, 2023 •

edited

chancez May 9, 2023

gandro left a comment

This comment was marked as outdated.

chancez commented May 9, 2023

kaworu May 10, 2023 •

edited

chancez May 10, 2023 •

edited

kaworu commented May 10, 2023

chancez commented May 10, 2023

Configure Renovate #1011

Configure Renovate #1011

Conversation

renovate bot commented May 4, 2023 • edited

Detected Package Files

Configuration

What to Expect

gandro left a comment

Choose a reason for hiding this comment

gandro May 8, 2023

Choose a reason for hiding this comment

chancez May 8, 2023 • edited

Choose a reason for hiding this comment

chancez May 8, 2023

Choose a reason for hiding this comment

chancez May 8, 2023

Choose a reason for hiding this comment

kaworu May 9, 2023

Choose a reason for hiding this comment

chancez May 9, 2023

Choose a reason for hiding this comment

kaworu left a comment

Choose a reason for hiding this comment

chancez commented May 8, 2023

chancez commented May 8, 2023 • edited

kaworu left a comment

Choose a reason for hiding this comment

kaworu May 9, 2023 • edited

Choose a reason for hiding this comment

chancez May 9, 2023

Choose a reason for hiding this comment

gandro left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

chancez commented May 9, 2023

kaworu May 10, 2023 • edited

Choose a reason for hiding this comment

chancez May 10, 2023 • edited

Choose a reason for hiding this comment

kaworu commented May 10, 2023

chancez commented May 10, 2023

renovate bot commented May 4, 2023 •

edited

chancez May 8, 2023 •

edited

chancez commented May 8, 2023 •

edited

kaworu May 9, 2023 •

edited

kaworu May 10, 2023 •

edited

chancez May 10, 2023 •

edited