Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Replace deprecated command with environment file #1049

Merged
merged 1 commit into from
May 24, 2023
Merged

.github: Replace deprecated command with environment file #1049

merged 1 commit into from
May 24, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented May 23, 2023

Description

Resolve #1048

Update .github/workflows/build-images-release.yaml and shell scripts to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' -o -name '*.sh'  | xargs egrep '\bset-output\b'

AS-IS

run: |
  echo ::set-output name=tag::${GITHUB_REF##*/}

TO-BE

run: |
  echo "tag=${GITHUB_REF##*/}" >> $GITHUB_OUTPUT

Signed-off-by: jongwooo <jongwooo.han@gmail.com>

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo requested review from a team as code owners May 23, 2023 20:10
@jongwooo jongwooo requested review from viktor-kurchenko and kaworu and removed request for a team May 23, 2023 20:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label May 23, 2023
Copy link

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaworu kaworu added 🧹 kind/cleanup This includes no functional changes. 🤖 area/CI Impacts the testing / continuous integration testing of the project. release-note/misc This PR makes changes that have no direct user impact. labels May 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label May 24, 2023
@glibsm glibsm merged commit f20d2c3 into cilium:master May 24, 2023
5 checks passed
@jongwooo jongwooo deleted the github/replace-deprecated-command-with-environment-file branch May 24, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 area/CI Impacts the testing / continuous integration testing of the project. 🧹 kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
4 participants