Make auth verdicts visible in CLI #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
This is needed in order to get the auth data from the flows. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/auth-visibility
branch
from
efbbd75
to
05bf9a4
Compare
This adds the auth verdict to the hubble flows CLI output inside the summary. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
Adds a failing GetNamespaces option to IOReaderObserver so it fits the ObserverClient interface again. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/auth-visibility
branch
from
b40b93f
to
54b8f28
Compare
meyskens
changed the title
rolinh
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kaworu
approved these changes
Jun 21, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
it says ready to merge. i merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds info on authentication type to the policy verdicts when it is available so you can see when a flow was allowed because of spire auth.