Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add hubble observe flows" #869

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Jan 24, 2023

Reverts #851

This broke using some flags, so revert until we can fix the regression.

@chancez chancez requested a review from a team as a code owner January 24, 2023 20:38
@chancez chancez requested review from kaworu and removed request for a team January 24, 2023 20:38
@maintainer-s-little-helper
Copy link

Commit 2a7d3d1 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin

@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label Jan 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jan 24, 2023
@chancez
Copy link
Contributor Author

chancez commented Jan 24, 2023

Dang that's what I get for clicking the revert button in GH. No sign-off.

This reverts commit fd73f31.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the revert-851-pr/chancez/hubble_observe_alias branch from 2a7d3d1 to ef2bdf1 Compare January 24, 2023 20:59
@chancez chancez merged commit 3028c66 into master Jan 24, 2023
@chancez chancez deleted the revert-851-pr/chancez/hubble_observe_alias branch January 24, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants