-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUID filter #919
Merged
Merged
UUID filter #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
⌨️ area/cli
Impacts the command line interface of any command in the repository.
🌟 kind/feature
This introduces new functionality.
release-note/minor
This PR introduces functionality that users may find relevant to operating Hubble.
labels
Mar 3, 2023
kaworu
requested review from
sayboras and
chancez
and removed request for
a team
March 3, 2023 10:29
kaworu
force-pushed
the
pr/kaworu/uuid-filter
branch
2 times, most recently
from
March 3, 2023 10:47
61b1838
to
a76e6d3
Compare
kaworu
added
the
dont-merge/blocked
PR/issue blocked by an external factor (be that PR, issue, or else)
label
Mar 3, 2023
Converting to draft as I wish to wait on #913 to be merged (will probably conflict on |
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch, it was not possible to find a flow by uuid. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
force-pushed
the
pr/kaworu/uuid-filter
branch
from
March 6, 2023 15:43
a76e6d3
to
2ec22c9
Compare
kaworu
removed
the
dont-merge/blocked
PR/issue blocked by an external factor (be that PR, issue, or else)
label
Mar 6, 2023
chancez
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
glibsm
approved these changes
Mar 6, 2023
sayboras
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on vendor changes ✔️
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⌨️ area/cli
Impacts the command line interface of any command in the repository.
🌟 kind/feature
This introduces new functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR introduces functionality that users may find relevant to operating Hubble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, it was not possible to find a flow by uuid.
See also cilium/cilium#23638 for context.