Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/observe: improve help message for --first and --all options #929

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Mar 13, 2023

No description provided.

The change in the patch was done for the `--last` option and it also
applies to the `--first` option.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added 📄 area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 13, 2023
@rolinh rolinh requested a review from a team as a code owner March 13, 2023 08:56
@rolinh rolinh requested review from kaworu and removed request for a team March 13, 2023 08:56
@rolinh rolinh force-pushed the pr/rolinh/observe-help-update branch 2 times, most recently from 97232b6 to 99350f8 Compare March 13, 2023 08:58
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolinh

cmd/observe/observe.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 13, 2023
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/observe-help-update branch from 99350f8 to 649f83e Compare March 13, 2023 09:51
@rolinh rolinh merged commit e36387c into master Mar 14, 2023
@rolinh rolinh deleted the pr/rolinh/observe-help-update branch March 14, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants