Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace stdin detection with --input-file flag which supports reading flows from a file or stdin #951

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Replace stdin detection with --input-file flag which supports reading flows from a file or stdin #951

merged 1 commit into from
Mar 27, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Mar 20, 2023 •
edited

Closes #942

Motivation as described in the GH issue. Basically, automatically detecting stdin is fraught with gotchas and can cause issues when trying to use hubble CLI in GitHub actions. Instead, add a flag to explicitly support reading flows from a file or stdin.

@chancez chancez requested a review from a team as a code owner March 20, 2023 17:02
@chancez chancez self-assigned this Mar 20, 2023
@chancez chancez requested review from kaworu and removed request for a team March 20, 2023 17:02
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Mar 20, 2023
@chancez chancez added release-note/major This PR introduces major new functionality to Hubble. breaking-change Breaks compatibility with previous versions labels Mar 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Mar 20, 2023
kaworu
kaworu requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chancez overall LGTM but I think we should rename the flag introduced by this PR, and also adapt the --server flag help on the way (e.g. add something like "ignored when --input-file is provided").

cmd/observe/observe.go Outdated Show resolved Hide resolved
@chancez
Replace stdin detection with --flows-file flag which supports reading…
9d02cbc 
… flows from a file or stdin

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez requested a review from kaworu March 22, 2023 23:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 27, 2023
@chancez chancez merged commit 04010e3 into master Mar 27, 2023
@chancez chancez deleted the pr/chancez/flows_file_flag branch March 27, 2023 16:02
@gandro gandro mentioned this pull request Jan 31, 2024
Closed
@pchaigno pchaigno changed the title Replace stdin detection with --flows-file flag which supports reading flows from a file or stdin Replace stdin detection with --input-file flag which supports reading flows from a file or stdin Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

Assignees

@chancez chancez

Labels
breaking-change Breaks compatibility with previous versions ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Hubble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace flows via stdin detection logic to an explicit CLI flag
2 participants
@chancez @kaworu