Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observe: traffic direction filter #976

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Apr 4, 2023

Before this patch, it was not possible to filter flows by traffic direction.

See also cilium/cilium#24120 for context.

@kaworu kaworu added ⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Apr 4, 2023
@kaworu kaworu requested review from a team as code owners April 4, 2023 08:23
@kaworu kaworu requested review from sayboras and chancez and removed request for a team April 4, 2023 08:23
@kaworu kaworu force-pushed the pr/kaworu/traffic-direction-filter branch from d4ae0c9 to 64dac69 Compare April 4, 2023 08:29
@kaworu kaworu force-pushed the pr/kaworu/traffic-direction-filter branch from 64dac69 to 426dd94 Compare April 4, 2023 09:02
@kaworu kaworu requested a review from rolinh April 4, 2023 09:02
@kaworu kaworu added the :basecamp: needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 13, 2023
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch, it was not possible to filter flows by traffic
direction.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@glibsm glibsm force-pushed the pr/kaworu/traffic-direction-filter branch from 426dd94 to 8294ada Compare April 13, 2023 22:19
@glibsm glibsm removed the :basecamp: needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 14, 2023
@kaworu kaworu merged commit 9bf9c3f into master Apr 14, 2023
5 checks passed
@kaworu kaworu deleted the pr/kaworu/traffic-direction-filter branch April 14, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants