Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCTP support #977

Merged
merged 2 commits into from
Apr 4, 2023
Merged

SCTP support #977

merged 2 commits into from
Apr 4, 2023

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Apr 4, 2023

Pulling @gandro for the recorder part.

@kaworu
printer: add SCTP support
c7e8183 
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu
recorder: add SCTP support
8930a5d 
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu added ⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Apr 4, 2023
@kaworu kaworu requested a review from gandro April 4, 2023 09:40
@kaworu kaworu requested a review from a team as a code owner April 4, 2023 09:40
gandro
gandro approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recorder change looks fine to me. Server-side we don't really support it at the moment, but we might in the future (which is why the API already supports it).

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 4, 2023
@rolinh rolinh merged commit 8b3dd6b into master Apr 4, 2023
5 checks passed
@rolinh rolinh deleted the pr/kaworu/sctp branch April 4, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. 🌟 kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaworu @gandro @rolinh