Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release instructions #994

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Update release instructions #994

merged 1 commit into from
Apr 24, 2023

Conversation

glibsm
Copy link
Member

@glibsm glibsm commented Apr 20, 2023

  1. Start with correct branch
  2. Avoid branch protection rules with better PR branch name

@glibsm glibsm added 🧹 kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 20, 2023
@glibsm glibsm requested a review from a team as a code owner April 20, 2023 22:30
@glibsm glibsm requested review from rolinh and removed request for a team April 20, 2023 22:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 20, 2023
@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label Apr 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Apr 20, 2023
kaworu
kaworu approved these changes Apr 21, 2023
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 21, 2023
@glibsm
Update release instructions
dd72bd5 
1. Start with correct branch
2. Avoid branch protection rules with better PR branch name

Signed-off-by: Glib Smaga <code@gsmaga.com>
@glibsm glibsm force-pushed the pr/glibsm/release-instructions branch from 89dec63 to dd72bd5 Compare April 21, 2023 19:40
gandro
gandro approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also noticed the branch name issue last time, but forgot to update the docs. Thanks for fixing!

@gandro gandro merged commit f5469f0 into master Apr 24, 2023
5 checks passed
@gandro gandro deleted the pr/glibsm/release-instructions branch April 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. 🧹 kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glibsm @gandro @kaworu @rolinh