Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDP support #239

Open
brb opened this issue Aug 11, 2023 · 14 comments · May be fixed by #339
Open

Add XDP support #239

brb opened this issue Aug 11, 2023 · 14 comments · May be fixed by #339
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brb
Copy link
Member

brb commented Aug 11, 2023

Details TBD.

@brb brb added enhancement New feature or request help wanted Extra attention is needed labels Aug 11, 2023
@Asphaltt
Copy link
Contributor

How about supporting tc-bpf together?

@brb
Copy link
Member Author

brb commented Aug 11, 2023

Do you mean tracing each individual BPF program? If yes, we are planning to do it for Cilium in the nearest future.

@Asphaltt
Copy link
Contributor

Do you mean tracing each individual BPF program?

Yes.

Recently, I discussed with @jschwinger233 that pwru traces XDP and tc-bpf. I was writing some code at that time.

But, currently, I'm busy fixing a kernel-bpf bug.🤔

@jschwinger233
Copy link
Member

Martynas, this is the guy @Asphaltt who managed to trace bpf tailcalls using kernel module, as I mentioned this Tuesday. 😁

@brb
Copy link
Member Author

brb commented Aug 11, 2023

Got it, small world 😄

@Asphaltt
Copy link
Contributor

Yeah, small world 😀

I'm afraid I can not help this issue for some time. I'm planning to do tailcalls tracing things after fixing the kernel-bpf bug.

@Asphaltt
Copy link
Contributor

Hi @brb ,

I'm glad to tell you that I just finished the POC of tracing TC bpf programs.

But, it's based on PR #266 and the latest go-ebpf library.

Recently, I'm fixing a tailcall issue of kernel-bpf whose progress is really slow. Then, I'm on this support now.

@brb
Copy link
Member Author

brb commented Oct 17, 2023

Hi @Asphaltt , thanks for the update!

I just finished the POC of tracing TC bpf programs

Great. I am curious what approach did you take (is it the same as Gray's one)?

@Asphaltt
Copy link
Contributor

is it the same as Gray's one

No. I trace TC bpf programs by listing then filtering all bpf progs.

Would you like to upgrade go-ebpf to latest version?

@brb
Copy link
Member Author

brb commented Oct 17, 2023

Would you like to upgrade go-ebpf to latest version?

Sure #269

@mscastanho
Copy link

Hi, is somebody actively working on this issue? If not, I volunteer to help, as I'm interested on this feature as well.

But I may need some assistance on the approach. I have tried to do a similar kind of filtered tracing on XDP programs using fentry/fexit on some personal projects before with no success. The verifier kept rejecting my program for invalid memory access when I tried to access packet data.

@brb
Copy link
Member Author

brb commented Jan 29, 2024

@mscastanho Hi, not sure whether @Asphaltt is working on it?

@Asphaltt
Copy link
Contributor

Hi, @brb, I will work on it when my PRs get merged. It'll be nice to work on it without other on-going PRs.

@brb
Copy link
Member Author

brb commented Jan 29, 2024

It'll be nice to work on it without other on-going PRs.

Sure, I just wanted to clarify whether @mscastanho can take this issue 😅

@Asphaltt Asphaltt linked a pull request Mar 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants