s32cinemagoer.py issues

[bachlava4eva]

Issue description

This isn't working for me, and I'm not much of a programmer, so unfortunately I can't diagnose it properly

This line is creating an issue with the "encoding" somehow
engine = sqlalchemy.create_engine(db_uri,encoding='utf-8', echo=False)

I'm getting the following error, even if I remove the encoding, etc.:

TypeError: MetaData.create_all() missing 1 required positional argument: 'bind'

I'm not sure what is going on. Is anyone able to still use this? I'm on Python 3.11 on the latest version of the cinemagoer library

[bachlava4eva]

imdb\parser\s3_init_.py", line 65 also has the line: encoding='utf-8', which is causing errors for some reason

[bachlava4eva]

I'm on sqlalchemy v.2.0.11

[bachlava4eva]

Yeah so, the solution is to move back to sqlalchemy v1.4

[alberanid]

I think we have some options:

1. force the use of 1.3 >= SQLAlchemy <= 1.4 in the requirements,
2. update the code to only use SQLAlchemy >= 2.0 (and force it in the requirements),
3. update the code to be able to use any version above 1.3

Option 3 is probably the nicer to the users, but I don't known how much effort it would take.

Does anyone have some experience migrating from SQLAlchemy 1.4 to 2.0?

[bachlava4eva]

I'm totally fine with using the different versions. Is there somewhere in the documentation that details which libraries and versions to use? I'm a beginning programmer, so I don't always know where to find this stuff haha

[alberanid]

the list of dependencies is in the requirements.txt file.

Before we can take a decision, we have to find out:

1. how different would be the code from 1.4 to 2.0
2. if it makes sense to support both
3. how widespread are 1.4 and 2.0

[bachlava4eva]

Thank you! I'm sorry I'm such a noob haha

[RealTehreal]

For all those Python-unaware people out there (like I am), here on how to exactly make it work:

pip install --upgrade sqlalchemy==1.4

Now, the error should be gone.

You're welcome.

[jimlynnjulian]

Unless I'm mistaken, some versions of SQAlchemy rely on an SQL library that has been removed from use.