-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Full body diodes not really filled when their color is changed #794
Comments
And if you look at it, it also seems that the I think that the full fix for this is: \documentclass[border=2.78mm]{standalone}
\usepackage[americanvoltages]{circuitikz}
\usepackage{xpatch}
\makeatletter
\xpatchcmd{\drawbodydiode}{%
\pgfnode{fulldiodeshape}{center}{}{pgf@bodydiode}{\pgfusepath{fill}}
}{%
\pgf@circ@maybe@color{transistor bodydiode/color}
\pgfnode{fulldiodeshape}{center}{}{pgf@bodydiode}{\pgfusepath{fill}}
}{}{\error}
\ctikzset{diode/stroke/.code = \pgf@circuit@strokediodetrue\pgf@circuit@fulldiodefalse}
\makeatother
\begin{document}
\begin{tikzpicture}[full diodes]
\draw[]
(0,0) to[D] ++(0,-1.25)
node[nigfete,bodydiode, anchor=D](){}
(2,0) to[Do] ++(0,-1.25)
node[nigfete,bodydiode, stroke diodes, anchor=D,
circuitikz/transistor bodydiode/color=red, fill=yellow](){}
(4,0) to[D-] ++(0,-1.25)
node[nigfete,bodydiode,tr circle,full diodes, anchor=D,
circuitikz/transistor bodydiode/color=red](){}
;
\end{tikzpicture}
\end{document} What seems incredible to me is that the problem that the fix from: |
Also, add a magic color selection thing to fix a fill problem in bodydiodes. Fixes circuitikz#794
Several new components, and a bug fix for a nasty long-standing bug about switching diode types. - Added a Relais-Shape (contributed by [Jakob "DraUX" on GitHub](circuitikz#795) - Added a center tap anchor for tube's filament (suggested by [user bogger33 on GitHub](circuitikz#792)) - Added neon lamps (two versions, suggested by [user bogger33 on GitHub](circuitikz#793)) - Added a configurable spark gap (suggested by [user bogger33 on GitHub](circuitikz#800)) - Fix a long-standing problem when [(locally) switching diode type](circuitikz#794)
Several new components, and a bug fix for a nasty long-standing bug about switching diode types. - Added a Relais-Shape (contributed by [Jakob "DraUX" on GitHub](circuitikz#795) - Added a center tap anchor for tube's filament (suggested by [user bogger33 on GitHub](circuitikz#792)) - Added neon lamps (two versions, suggested by [user bogger33 on GitHub](circuitikz#793)) - Added a configurable spark gap (suggested by [user bogger33 on GitHub](circuitikz#800)) - Fix a long-standing problem when [(locally) switching diode type](circuitikz#794)
There seems to be a problem when changing the color of full bodydiodes... (problem spotted answering to this question)
This seems to be fixable by:
...but I have to think a bit about it.
The text was updated successfully, but these errors were encountered: