Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support component plugins #104

Closed
jkeifer opened this issue Jan 20, 2022 · 2 comments · Fixed by #150
Closed

Support component plugins #104

jkeifer opened this issue Jan 20, 2022 · 2 comments · Fixed by #150
Assignees
Labels
Milestone

Comments

@jkeifer
Copy link
Collaborator

jkeifer commented Jan 20, 2022

Can we create a way to specify python packages that implement cirrus components as "plugins"? Rather than showing up as built-in or with a relative path in a project, they would display with the name of the plugin package defining them.

If we can work this out and it seems viable, we should split all nonessential components out of the builtins and put them in a separate package (or set of packages) so they don't clutter up projects that do not require them.

@jkeifer jkeifer added this to the 0.6.0 milestone Jan 20, 2022
@jkeifer jkeifer self-assigned this May 25, 2022
@jkeifer
Copy link
Collaborator Author

jkeifer commented May 25, 2022

Plugin support is more or less implemented in #138, though supporting searching them for components will need a few more pieces put into place. Also we should document the plugin interface(s). Currently plugins can be registered via setuptools entrypoints, cirrus.plugins to point to the plugin package and cirrus.commands to add new commands to the cli.

We could easily add cirrus.components or something like that to point to a module containing feeders/functions/tasks/workflows dirs like cirrus.builtins, and we could have the component search automatically register those paths.

I suppose this should also support cloudformation resources as well, so maybe that entrypoint name is too specific.

@jkeifer jkeifer added the small label May 25, 2022
@jkeifer jkeifer changed the title Investigate cirrus plugins Support component plugins May 25, 2022
@jkeifer
Copy link
Collaborator Author

jkeifer commented Aug 24, 2022

Naming is hard. I am going with cirrus.resources for this before I change my mind yet again.

@jkeifer jkeifer mentioned this issue Aug 28, 2022
@jkeifer jkeifer linked a pull request Sep 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant