Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when packaging when Lambdas and cirrus-lib have duplicated requirements #106

Closed
jkeifer opened this issue Jan 21, 2022 · 1 comment · Fixed by #150
Closed

Error when packaging when Lambdas and cirrus-lib have duplicated requirements #106

jkeifer opened this issue Jan 21, 2022 · 1 comment · Fixed by #150
Labels
bug Something isn't working
Milestone

Comments

@jkeifer
Copy link
Collaborator

jkeifer commented Jan 21, 2022

With the way that we now inject the locally-install cirrus-lib and extend lambda requirements with those of cirrus-lib, it is possible that we end up with duplicate specifications for a requirement when it is required by both the lambda and cirrus-lib.

How to solve this problem is less than straightforward. If only we could pip install cirrus-lib from the local env then pip could resolve these requirements issues for us, but that alone doesn't really work. I do wonder though if we could import something from pip that would resolve the set of dependencies we need based on those listed. Trying to roll that ourselves sounds painful and rife with risk.

Until we have a solution to this issue, users that encounter an error about duplicate requirements will need to remove/comment out the duplicated requirement(s) in the affected lambda definitions(s).

@jkeifer jkeifer added the bug Something isn't working label Jan 21, 2022
@jkeifer jkeifer added this to the 0.6.0 milestone Jan 21, 2022
@jkeifer jkeifer modified the milestones: 0.7.0, 0.8.0 May 25, 2022
@jkeifer
Copy link
Collaborator Author

jkeifer commented May 25, 2022

Let's detect this situation and raise an error that points to this issue or something.

@jkeifer jkeifer mentioned this issue Aug 29, 2022
@jkeifer jkeifer linked a pull request Sep 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant