Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cirrus serverless deploy does not fail if serverless binary is not present #134

Closed
marchuffnagle opened this issue Apr 25, 2022 · 0 comments · Fixed by #150
Closed

cirrus serverless deploy does not fail if serverless binary is not present #134

marchuffnagle opened this issue Apr 25, 2022 · 0 comments · Fixed by #150
Assignees
@jkeifer
Labels
bug Something isn't working small
Milestone
0.7.0

Comments

@marchuffnagle
Copy link
Contributor

The cirrus CLI detects if the serverless binary is missing. If it is, it displays a message saying that it's missing, but then exits cleanly (returning a status code of 0). If shell scripts are checking for the return value of this command, they are going to assume that the deployment succeeded and continue on. It should exit with some non-zero status code in this case.

cirrus-geo/src/cirrus/cli/commands.py

Line 116 in 8f11903

logger.error('No serverless binary; have you run `npm install`?')

@jkeifer jkeifer added the bug Something isn't working label May 25, 2022
@jkeifer jkeifer self-assigned this May 25, 2022
@jkeifer jkeifer added this to the 0.7.0 milestone May 25, 2022
@jkeifer jkeifer added the small label May 25, 2022
jkeifer added a commit that referenced this issue May 27, 2022
@jkeifer
non-0 exit codes sls cmd errors closing #134
0cc966b
jkeifer added a commit that referenced this issue Aug 24, 2022
@jkeifer
non-0 exit codes sls cmd errors closing #134
1c3925b
@jkeifer jkeifer mentioned this issue Aug 24, 2022
Merged
@jkeifer jkeifer linked a pull request Sep 8, 2022 that will close this issue
Prep 0.7.0 #150
Merged
jkeifer added a commit that referenced this issue Sep 13, 2022
@jkeifer
non-0 exit codes sls cmd errors closing #134
ac5c9fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkeifer jkeifer

Labels
bug Something isn't working small
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Prep 0.7.0 cirrus-geo/cirrus-geo
2 participants
@jkeifer @marchuffnagle