Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in ProcessPayload.set_id() #225

Open
jkeifer opened this issue Jul 31, 2023 · 0 comments
Open

Issues in ProcessPayload.set_id() #225

jkeifer opened this issue Jul 31, 2023 · 0 comments

Comments

@jkeifer
Copy link
Collaborator

jkeifer commented Jul 31, 2023

We definitely have a bug here:

input_collections = cols if len(cols) != 0 else "none"
. If no collection is specified on the items and collections is not set in the process block then we get a string none and end up with an id like n/o/n/e/...

At the very least we need to wrap that in a tuple or something.

But generally, the whole function could use some thought. What payload fields are we still supporting? process.collections seems really confusing when we have process.upload_options.collections. What is the deal with process.input_collections, is that still supposed to be a thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant