Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overly-broad exception expectations in tests #271

Open
jkeifer opened this issue May 3, 2024 · 0 comments
Open

Fix overly-broad exception expectations in tests #271

jkeifer opened this issue May 3, 2024 · 0 comments

Comments

@jkeifer
Copy link
Collaborator

jkeifer commented May 3, 2024

(This is part of work currently staged on #268.)

We are ignoring the linter rules B017 and PT011 in test files. These flag overly-broad exceptions in pytest.raises() calls, which is a problem as unexpected things could go wrong in the code and be missed.

We need to remove the ignores for those rules and audit/fix each flagged occurrence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant