Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing spec details, errors #88

Open
bdarcus opened this issue Jun 13, 2020 · 3 comments
Open

missing spec details, errors #88

bdarcus opened this issue Jun 13, 2020 · 3 comments
Labels

Comments

@bdarcus
Copy link
Member

bdarcus commented Jun 13, 2020

This comment identifies some missing spec details or errors.

@bwiernik
Copy link
Member

bwiernik commented Jun 25, 2020

As you work through these, could you perhaps post a list of tests you think might qualify, beyond this one?

I'm sorry, I should have been keeping track. Just a couple things I can recall off the top of my head:

  • the test cases expect a conversion of unicode superscripted letters to csl <sup> elements
  • the list of "stop words" for title case in the spec do not seem to be complete; I had to add: "about", plus name particles "van", "von", "de", "d", "l".
  • in titlecase, non-English characters don't get uppercased, even in an English locale + citation; this isn't in the spec
  • in general, the spec is confusing about titlecase. It seems that things in ALL UPPERCASE don't get transformed, even though the spec says "For uppercase strings, the first character of each word remains capitalized. All other letters are lowercased." Maybe by "uppercase" the spec means just that the first letter is uppercase and the rest lowercase, but if so that's incredibly confusing, esp. with the subsequnet use of "mixed case."
  • the spec says that the label element in names "must be included after the cs:name and cs:et-al elements, but before the cs:substitute element." This is false; it can come either before or after the name element. Moreover, its position relative to the name element turns out to be significant (it determines whether the label is printed before or after the name). I had to discover this by experimentation.

Originally posted by @jgm in citation-style-language/test-suite#25 (comment)

@bwiernik
Copy link
Member

the spec says that the label element in names "must be included after the cs:name and cs:et-al elements, but before the cs:substitute element." This is false; it can come either before or after the name element. Moreover, its position relative to the name element turns out to be significant (it determines whether the label is printed before or after the name). I had to discover this by experimentation.

This one I think we should fix. The spec is correct in my opinion. The position of the label relative to the name should be controlled by the form. verb and verb-short com before the name, others come after. Does that sound right @adam3smith @rmzelle ?

@bwiernik bwiernik added the 1.0.2 label Jun 25, 2020
@bwiernik
Copy link
Member

bwiernik commented Nov 8, 2020

With respect to casing applied to non-Latin characters, how do we reconcile the different behavior in these two tests:
https://github.com/citation-style-language/test-suite/blob/master/processor-tests/humans/textcase_LocaleUnicode.txt
https://github.com/citation-style-language/test-suite/blob/4c1e0b6635167018205d93db500b2daa233dab8e/processor-tests/humans/textcase_NonEnglishChars.txt

In the first, Turkish letters are uppercased when text-case="uppercase". In the second, Greek letters are not uppercased when text-case="title". What is the distinction here? Is it that Turkish letters use the Latin alphabet (with accents)? Or is it that uppercase always applies, regardless of item language or script? Or am I overthinking this and it's that i is interpreted as English "i" in English but Turkish "i" in Turkish?

@jgm @fbennett Is there more of a pattern in the test suite on this point?

Uppercase is rarely used enough in the sciences, that I don't think there is much issue with applying it universally and limiting the "only English items, Latin characters) restriction to title case.

Thoughts @adam3smith @fbennett @jgm @denismaier ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants