Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing punctuation #44

Open
jgm opened this issue Oct 9, 2020 · 1 comment
Open

Collapsing punctuation #44

jgm opened this issue Oct 9, 2020 · 1 comment
Assignees
Labels

Comments

@jgm
Copy link

jgm commented Oct 9, 2020

I'm baffled about how consecutive punctuation is expected to be handled; the test suite seems to do different things in different places, and often those things seem strange.

For example in affix_WithCommas.txt, ,; seems to collapse to ,, but in punctuation_FullMonty*.txt it stays ,;.

I can't think of a case where I'd actually want to see ,; -- and it seems to me that collapsing to ; makes more sense than collapsing to ,.

@fbennett
Copy link
Member

fbennett commented Nov 20, 2020

Sorry for the delay in responding. (I've turned on notifications now.)

In affix_WithCommas.txt, the comma is the leading character of a user-supplied suffix, and overrides the style-supplied delimiter. The CSL Specification doesn't say anything about user-supplied suffixes, but overriding the delimiter seems the right thing to do there.

In punctuation_FullMontyPlain.txt, both punctuation marks are supplied by the style, so collapsing rules are applied, which mostly just aim to avoid duplicate punctuation. (The controlling map in citeproc-js is here in case it's useful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants