Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid split packages #1054

Open
christophd opened this issue Nov 10, 2023 · 2 comments
Open

Avoid split packages #1054

christophd opened this issue Nov 10, 2023 · 2 comments
Labels
good first issue A good point to start from for new contributrs Type: Enhancement Type: Maintenance

Comments

@christophd
Copy link
Member

Citrus uses some split packages which is considered a bad practice.

Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in multiple archives:

  • "org.citrusframework.common" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.xml" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.validation.script.sql" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.validation.script" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.report" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.context" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.annotations" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.functions" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.message.correlation" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.validation.xml" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.main" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.validation" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.variable" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.util" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.validation.matcher" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.variable.dictionary" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.container" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.endpoint" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.main.scan" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.endpoint.resolver" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.message" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.server" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.endpoint.adapter.mapping" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.condition" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
  • "org.citrusframework.log" found in [org.citrusframework:citrus-api::jar, org.citrusframework:citrus-base::jar]
@christophd christophd added Type: Enhancement Type: Maintenance good first issue A good point to start from for new contributrs labels Nov 10, 2023
@bbortt
Copy link
Collaborator

bbortt commented Nov 12, 2023

out of curiosity, what tool did you use for scanning?

@christophd
Copy link
Member Author

The Quarkus SplitPackageProcessor reported this to me while running Citrus tests with Quarkus dev services framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good point to start from for new contributrs Type: Enhancement Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophd @bbortt