Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA status showing "pending" after signing CLA w/ email address from commit #441

Closed
curiouslychase opened this issue May 24, 2019 · 2 comments

Comments

@curiouslychase
Copy link

curiouslychase commented May 24, 2019

URL to the linked Repo/Org: webpack/webpack-cli#892

What is the expected result?

Signing the CLA for a PR with a commit that has:

  1. a single author
  2. in a GitHub org (with the same email address as the user) [this PR was done in an org called chaseadamsio-forks]
  3. with the same email address in the commit as is in the GitHub email settings

should set the check for CLA signing to passed.

What happens instead?

Status is still pending.

image

image

Commit:

commit 91239ef5d959ab7bc2dd56843b6ec3168dffa152 (HEAD -> fixWatchOptions, origin/fixWatchOptions)
Author: Chase Adams <realchaseadams@gmail.com>
Date:   Thu May 23 22:30:25 2019 -0700

    cli: fix watch options for array config
    
    Issue #4594 points out that watch options aren't being honored when the
    Webpack config is an Array. In cases when it's an array, there may not
    be a firstOptions.watchOptions, but there will be an options.watchOptions.
    
    In the current implementation, when the Webpack compiler watch method is
    called with watchOptions and the Webpack config is an array, watchOptions
    will be `true` and not an object.
@KharitonOff
Copy link
Contributor

@chaseadamsio sometimes the update request of the CLA assistant doesn't reach GitHub. The easiest way to let CLA assistant update the PR status is to retrigger a PR webhook by making a change on the PR (pushing a new commit or by closing and reopening the PR).

@curiouslychase
Copy link
Author

👍 I force pushed a rebase of w/ an empty commit and that did the trick. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants