Flags with multiple values wrongly consumes following positional arguments

[althonos]

Rust Version

rustc 1.41.0-nightly (25d8a9494 2019-11-29)

Affected Version of clap

clap v2.33.0

Expected Behavior Summary

Given a program with the following usage:

program [-g path] [file ...]

where both file and -g can take multiple values. parsing

program -g x y z

should give:

ArgMatches { 
    args: {
        "g": MatchedArg { occurs: 1, indices: [2], vals: ["x"] },
        "file" MatchedArg { occurs: 2, indices: [3, 4], vals: ["y", "z"] },
    }, 
    ...
}

Actual Behavior Summary

program -g x y z

gives

ArgMatches { 
    args: {
        "g": MatchedArg { occurs: 1, indices: [2, 3, 4], vals: ["x", "y", "z"] }
    }, 
    ...
}

Steps to Reproduce the issue

N/A

Sample Code or Link to Sample Code

App::new("cksfv.rs")
    .arg(Arg::with_name("g")
        .short("g")
        .value_name("path")
        .takes_value(true)
        .multiple(true))
    .arg(Arg::with_name("file")
        .index(1)
        .value_name("file")
        .multiple(true))

Debug output

Compile clap with cargo features "debug" such as:

[dependencies]
clap = { version = "2", features = ["debug"] }

The output may be very long, so feel free to link to a gist or attach a text file

Debug Output

DEBUG:clap:Parser::propagate_settings: self=cksfv.rs, g_settings=AppFlags(

(empty),

)

DEBUG:clap:Parser::get_matches_with;

DEBUG:clap:Parser::create_help_and_version;

DEBUG:clap:Parser::create_help_and_version: Building --help

DEBUG:clap:Parser::create_help_and_version: Building --version

DEBUG:clap:Parser::get_matches_with: Begin parsing '"-g"' ([45, 103])

DEBUG:clap:Parser::is_new_arg:"-g":NotFound

DEBUG:clap:Parser::is_new_arg: arg_allows_tac=false

DEBUG:clap:Parser::is_new_arg: - found

DEBUG:clap:Parser::is_new_arg: starts_new_arg=true

DEBUG:clap:Parser::possible_subcommand: arg="-g"

DEBUG:clap:Parser::get_matches_with: possible_sc=false, sc=None

DEBUG:clap:ArgMatcher::process_arg_overrides:None;

DEBUG:clap:Parser::parse_short_arg: full_arg="-g"

DEBUG:clap:Parser::parse_short_arg:iter:g

DEBUG:clap:Parser::parse_short_arg:iter:g: Found valid opt

DEBUG:clap:Parser::parse_short_arg:iter:g: p[0]=[], p[1]=[]

DEBUG:clap:Parser::parse_opt; opt=g, val=None

DEBUG:clap:Parser::parse_opt; opt.settings=ArgFlags(MULTIPLE | EMPTY_VALS | TAKES_VAL | DELIM_NOT_SET)

DEBUG:clap:Parser::parse_opt; Checking for val...None

DEBUG:clap:ArgMatcher::inc_occurrence_of: arg=g

DEBUG:clap:ArgMatcher::inc_occurrence_of: first instance

DEBUG:clap:Parser::groups_for_arg: name=g

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:Parser::parse_opt: More arg vals required...

DEBUG:clap:Parser:get_matches_with: After parse_short_arg Opt("g")

DEBUG:clap:Parser::get_matches_with: Begin parsing '"x"' ([120])

DEBUG:clap:Parser::is_new_arg:"x":Opt("g")

DEBUG:clap:Parser::is_new_arg: arg_allows_tac=false

DEBUG:clap:Parser::is_new_arg: probably value

DEBUG:clap:Parser::is_new_arg: starts_new_arg=false

DEBUG:clap:Parser::add_val_to_arg; arg=g, val="x"

DEBUG:clap:Parser::add_val_to_arg; trailing_vals=false, DontDelimTrailingVals=false

DEBUG:clap:Parser::add_single_val_to_arg;

DEBUG:clap:Parser::add_single_val_to_arg: adding val..."x"

DEBUG:clap:Parser::groups_for_arg: name=g

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:ArgMatcher::needs_more_vals: o=g

DEBUG:clap:Parser::get_matches_with: Begin parsing '"y"' ([121])

DEBUG:clap:Parser::is_new_arg:"y":Opt("g")

DEBUG:clap:Parser::is_new_arg: arg_allows_tac=false

DEBUG:clap:Parser::is_new_arg: probably value

DEBUG:clap:Parser::is_new_arg: starts_new_arg=false

DEBUG:clap:Parser::add_val_to_arg; arg=g, val="y"

DEBUG:clap:Parser::add_val_to_arg; trailing_vals=false, DontDelimTrailingVals=false

DEBUG:clap:Parser::add_single_val_to_arg;

DEBUG:clap:Parser::add_single_val_to_arg: adding val..."y"

DEBUG:clap:Parser::groups_for_arg: name=g

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:ArgMatcher::needs_more_vals: o=g

DEBUG:clap:Parser::get_matches_with: Begin parsing '"z"' ([122])

DEBUG:clap:Parser::is_new_arg:"z":Opt("g")

DEBUG:clap:Parser::is_new_arg: arg_allows_tac=false

DEBUG:clap:Parser::is_new_arg: probably value

DEBUG:clap:Parser::is_new_arg: starts_new_arg=false

DEBUG:clap:Parser::add_val_to_arg; arg=g, val="z"

DEBUG:clap:Parser::add_val_to_arg; trailing_vals=false, DontDelimTrailingVals=false

DEBUG:clap:Parser::add_single_val_to_arg;

DEBUG:clap:Parser::add_single_val_to_arg: adding val..."z"

DEBUG:clap:Parser::groups_for_arg: name=g

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:ArgMatcher::needs_more_vals: o=g

DEBUG:clap:ArgMatcher::process_arg_overrides:Some("g");

DEBUG:clap:Parser::remove_overrides:[];

DEBUG:clap:Validator::validate;

DEBUG:clap:Parser::add_defaults;

DEBUG:clap:Parser::add_defaults:iter:g: doesn't have conditional defaults

DEBUG:clap:Parser::add_defaults:iter:g: doesn't have default vals

DEBUG:clap:Parser::add_defaults:iter:file: doesn't have conditional defaults

DEBUG:clap:Parser::add_defaults:iter:file: doesn't have default vals

DEBUG:clap:Validator::validate: needs_val_of="g"

DEBUG:clap:Validator::validate_required: required=[];

DEBUG:clap:Validator::validate_blacklist;

DEBUG:clap:Validator::validate_blacklist:iter:g;

DEBUG:clap:Parser::groups_for_arg: name=g

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:Validator::validate_matched_args;

DEBUG:clap:Validator::validate_matched_args:iter:g: vals=[

"x",

"y",

"z",

]

DEBUG:clap:Validator::validate_arg_num_vals:g

DEBUG:clap:Validator::validate_arg_values: arg="g"

DEBUG:clap:Validator::validate_arg_requires:g;

DEBUG:clap:Validator::validate_arg_num_occurs: a=g;

DEBUG:clap:usage::create_usage_with_title;

DEBUG:clap:usage::create_usage_no_title;

DEBUG:clap:usage::get_required_usage_from: reqs=[], extra=None

DEBUG:clap:usage::get_required_usage_from: after init desc_reqs=[]

DEBUG:clap:usage::get_required_usage_from: no more children

DEBUG:clap:usage::get_required_usage_from: final desc_reqs=[]

DEBUG:clap:usage::get_required_usage_from: args_in_groups=[]

DEBUG:clap:usage::needs_flags_tag;

DEBUG:clap:usage::needs_flags_tag:iter: f=hclap_help;

DEBUG:clap:usage::needs_flags_tag:iter: f=vclap_version;

DEBUG:clap:usage::needs_flags_tag: [FLAGS] not required

DEBUG:clap:usage::get_args_tag;

DEBUG:clap:usage::get_args_tag:iter:file:

DEBUG:clap:Parser::groups_for_arg: name=file

DEBUG:clap:Parser::groups_for_arg: No groups defined

DEBUG:clap:usage::get_args_tag:iter: 1 Args not required or hidden

DEBUG:clap:usage::get_args_tag:iter: Exactly one, returning 'file'

DEBUG:clap:PosBuilder::name_no_brackets;

DEBUG:clap:PosBuilder:name_no_brackets: val_names={

0: "file",

}

DEBUG:clap:usage::create_help_usage: usage=claptest [OPTIONS] [--] [file]...

DEBUG:clap:ArgMatcher::get_global_values: global_arg_vec=[]

ArgMatches { args: {"g": MatchedArg { occurs: 1, indices: [2, 3, 4], vals: ["x", "y", "z"] }}, subcommand: None, usage: Some("USAGE:\n    claptest [OPTIONS] [--] [file]...") }

[pksunkara]

I think this is intended and the right way. If you want to separate positional arguments from options you have to use -- while calling the cli which is a standardized way of these type of options.

[althonos]

@pksunkara : even if this is the intended behaviour within clap, this does not make that much sense compared to the UNIX command lines. You do grep print -R --include=\*.py --include=\*.rs, not grep print -R --include=\*.py \*.rs when you want to pass multiple values for the same flags, for instance.

[CreepySkeleton]

If you want to implement the CLI as you described, you should use number_of_values

App::new("cksfv.rs")
    .arg(Arg::with_name("g")
        .short("g")
        .value_name("path")
        .takes_value(true)
        .multiple(true)
        .number_of_values(1))
    .arg(Arg::with_name("file")
        .index(1)
        .value_name("file")
        .multiple(true))

[CreepySkeleton]

See the documentation at https://docs.rs/clap/2.33.0/i686-apple-darwin/clap/struct.Arg.html#method.multiple

[CreepySkeleton]

I guess this is solved, so closing. Feel free to reopen.