[3.0.0-beta.1] Non-unique arguments runtime panic #1969

catleeball · 2020-06-09T06:45:10Z

catleeball
Jun 9, 2020

I'm struggling to port my clap arguments from 2.33.1 to 3.0.0-beta.1 and I'm not sure if I'm encountering a bug or if I've messed up something syntactically. It might be a good to improve the error message if its working as intended.

Here's my main function that compiles and runs in 2.3.3.1:

extern crate clap;
use clap::{crate_version, App, Arg};
use headless_chrome::{protocol::page::ScreenshotFormat, Browser};

fn main() -> Result<(), failure::Error> {
    let args = App::new("shotweb")
        .about("Take screenshots of Chrome-rendered webpages.")
        .version(crate_version!())
        .arg(Arg::with_name("url")
            .help("URL or file to take a screencap of. i.e. https://example.com or file:///path/to/file.html")
            .index(1)
            .required(true))
        .arg(Arg::with_name("output-path")
            .help("Local file path to save screenshot image to.")
            .short("o")
            .takes_value(true)
            .default_value("/tmp/screenshot.png"))
        .arg(Arg::with_name("element")
            .help("CSS selector of element to screenshot.")
            .short("e")
            .takes_value(true))
        .arg(Arg::with_name("image-format")
            .help("Local file path to save screenshot image to.")
            .short("i")
            .takes_value(true)
            .default_value("png")
            .possible_values(&["png", "jpg"]))
        .get_matches();
    let url: &str = args.value_of("url").unwrap();
    let output_path: &str = args.value_of("output-path").unwrap();

    let img = screenshot_webpage(url)?;
    std::fs::write(output_path, img)?;
    Ok(())
}

And here is my v3 attempt:

use clap::{crate_version, App, Arg};
use headless_chrome::{protocol::page::ScreenshotFormat, Browser};

fn main() -> Result<(), failure::Error> {
    let args = App::new("shotweb")
        .about("Take screenshots of Chrome-rendered webpages.")
        .version(crate_version!())
        .arg(Arg::new("url")
            .about("URL or file to take a screencap of. i.e. https://example.com or file:///path/to/file.html")
            .index(1)
            .required(true))
        .arg(Arg::new("output-path")
            .about("Local file path to save screenshot image to.")
            .short('o')
            .takes_value(true)
            .default_value("/tmp/screenshot.png"))
        .arg(Arg::new("element")
            .about("CSS selector of element to screenshot.")
            .short('e')
            .takes_value(true))
        .arg(Arg::new("image-format")
            .about("Local file path to save screenshot image to.")
            .short('i')
            .takes_value(true)
            .default_value("png")
            .possible_values(&["png", "jpg"]))
        .get_matches();
    let url: &str = args.value_of("url").unwrap();
    let output_path: &str = args.value_of("output-path").unwrap();

    let img = screenshot_webpage(url)?;
    std::fs::write(output_path, img)?;
    Ok(())
}

which returns a not-very-enlightening error at runtime:

shotweb on  args via 🦀 v1.44.0
23:31 ➜ cargo build
   Compiling shotweb v0.1.0 (/Users/int/src/shotweb)
    Finished dev [unoptimized + debuginfo] target(s) in 2.87s

shotweb on  args via 🦀 v1.44.0
23:31 ➜ RUST_BACKTRACE=1 ./target/debug/shotweb file:////Users/int/src/tmnt_wikipedia_bot/assets/html/tmnt.html
thread 'main' panicked at 'Argument names must be unique, but '' is in use by more than one argument or group', /Users/int/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.0.0-beta.1/src/build/app/mod.rs:1613:13
stack backtrace:
[1]    38054 segmentation fault  RUST_BACKTRACE=1 ./target/debug/shotweb

shotweb on  args via 🦀 v1.44.0
23:40 ✗

Is anyone able to spot the issue I'm having? In the v3 beta version I've also moved it back into main, in case there was for some reason something strange with dropping get_matches into its own function.

Any advice is appreciated! Thanks in advance.

Answered by pksunkara

Jun 9, 2020

You are following master branch README for 3.0.0-beta.1 release. It will not work because there is a breaking change in the master branch after 3.0.0-beta.1 was released. Please check out the tag and then follow the README if you want to try out the beta.

Additionally, I would suggest you to wait for v3 to come out properly because we still plan to break more things.

View full answer

pksunkara · 2020-06-09T06:47:23Z

pksunkara
Jun 9, 2020
Maintainer

You are following master branch README for 3.0.0-beta.1 release. It will not work because there is a breaking change in the master branch after 3.0.0-beta.1 was released. Please check out the tag and then follow the README if you want to try out the beta.

Additionally, I would suggest you to wait for v3 to come out properly because we still plan to break more things.

3 replies

catleeball Jun 9, 2020
Author

Understood, thank you @pksunkara !

lenaschimmel Jun 16, 2020

I have the same problem with my code.

If I understand it correctly, @catleeball reverted the code back to use clap version 2.33.1 which fixed the issue for them.

And the release 3.0.0-beta.1 is broken as stated issue #1965, which was fixed in PR #1966. The PR has been merged to master, but there has not yet been a release to crates.io which includes that PR, right?

So, if I do not want to revert back to clap version 2.x, the next best solution would be to directly use master, correct?

CreepySkeleton Jun 16, 2020

I suppose he best solution would be to make a point release (also beta) that will bring the README and examples on par with latest crates.io release. @pksunkara @kbknapp Any objections?

Dylan-DPC-zz · 2020-06-10T09:36:18Z

Dylan-DPC-zz
Jun 10, 2020

The whole point of beta releases is that users can try out and report bugs before the main version is released. If this wasn't the motivation of pushing for beta releases, then I don't understand the significance of having the beta release

0 replies

pksunkara · 2020-06-10T10:16:44Z

pksunkara
Jun 10, 2020
Maintainer

Let me clarify a bit more. Please wait for 3.0 before using clap in Production. The beta releases as advertised are just for trying out.

0 replies

catleeball · 2020-06-11T23:58:22Z

catleeball
Jun 11, 2020
Author

I forgot I was going to ask: should I file a bug about the error I encountered above, or is this issue already known and being addressed in the pipeline?

1 reply

Dylan-DPC-zz Jun 11, 2020

I would prefer so, it is better having this tracked even though it is redundant.

pksunkara · 2020-06-12T00:00:11Z

pksunkara
Jun 12, 2020
Maintainer

This is not a bug. You were just mixing up the versions. We already addressed it.

0 replies

pksunkara · 2020-06-12T00:00:50Z

pksunkara
Jun 12, 2020
Maintainer

To clarify, you were using code shown in master README with 3.0.0-beta.1 which shouldn't work because there are some breaking changes in master.

0 replies

catleeball · 2020-06-12T00:02:35Z

catleeball
Jun 12, 2020
Author

I compiled and ran this code using 3.0.0-beta.1. Do you mean that I had a syntax issue in my code that was changed in 3.0? Apologies for the confusion.

0 replies

pksunkara · 2020-06-12T00:04:14Z

pksunkara
Jun 12, 2020
Maintainer

Yeah. That is what I meant in

You are following master branch README for beta.1 release. It will not work because there is a breaking change.

Let me edit that comment with more clarity since there seems to be misunderstanding.

0 replies

catleeball · 2020-06-12T00:05:14Z

catleeball
Jun 12, 2020
Author

Got it, understood! Thanks for the info. 🙂

0 replies

pksunkara · 2020-06-17T07:50:56Z

pksunkara
Jun 17, 2020
Maintainer

I don't think we should do it. I want to finish off all the planned breaking changes before the next release (rc) and ask people for feedback.

…

On Wed, Jun 17, 2020, 01:57 CreepySkeleton ***@***.***> wrote: I suppose he best solution would be to make a point release (also beta) that will bring the README and examples on par with latest crates.io release. @pksunkara <https://github.com/pksunkara> @kbknapp <https://github.com/kbknapp> Any objections? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1969 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABKU34PC7QT6L3IE4DZSXLRXABFNANCNFSM4NZDEIAA> .

0 replies

pksunkara · 2020-06-17T07:52:14Z

pksunkara
Jun 17, 2020
Maintainer

3.0.0-beta.1 is not broken. You were just following the wrong examples. If you go to the examples folder of that tag on GitHub and follow them, it will work. On Wed, Jun 17, 2020, 09:50 Pavan Kumar Sunkara <pavan.sss1991@gmail.com> wrote:

…

I don't think we should do it. I want to finish off all the planned breaking changes before the next release (rc) and ask people for feedback. On Wed, Jun 17, 2020, 01:57 CreepySkeleton ***@***.***> wrote: > I suppose he best solution would be to make a point release (also beta) > that will bring the README and examples on par with latest crates.io > release. @pksunkara <https://github.com/pksunkara> @kbknapp > <https://github.com/kbknapp> Any objections? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1969 (reply in thread)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABKU34PC7QT6L3IE4DZSXLRXABFNANCNFSM4NZDEIAA> > . >

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.0.0-beta.1] Non-unique arguments runtime panic #1969

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 11 comments 4 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

[3.0.0-beta.1] Non-unique arguments runtime panic #1969

catleeball Jun 9, 2020

Replies: 11 comments · 4 replies

pksunkara Jun 9, 2020 Maintainer

catleeball Jun 9, 2020 Author

lenaschimmel Jun 16, 2020

CreepySkeleton Jun 16, 2020

Dylan-DPC-zz Jun 10, 2020

pksunkara Jun 10, 2020 Maintainer

catleeball Jun 11, 2020 Author

Dylan-DPC-zz Jun 11, 2020

pksunkara Jun 12, 2020 Maintainer

pksunkara Jun 12, 2020 Maintainer

catleeball Jun 12, 2020 Author

pksunkara Jun 12, 2020 Maintainer

catleeball Jun 12, 2020 Author

pksunkara Jun 17, 2020 Maintainer

pksunkara Jun 17, 2020 Maintainer

catleeball
Jun 9, 2020

Replies: 11 comments 4 replies

pksunkara
Jun 9, 2020
Maintainer

catleeball Jun 9, 2020
Author

Dylan-DPC-zz
Jun 10, 2020

pksunkara
Jun 10, 2020
Maintainer

catleeball
Jun 11, 2020
Author

pksunkara
Jun 12, 2020
Maintainer

pksunkara
Jun 12, 2020
Maintainer

catleeball
Jun 12, 2020
Author

pksunkara
Jun 12, 2020
Maintainer

catleeball
Jun 12, 2020
Author

pksunkara
Jun 17, 2020
Maintainer

pksunkara
Jun 17, 2020
Maintainer