Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arg! to set Actions #3795

Closed
epage opened this issue Jun 6, 2022 · 0 comments · Fixed by #3972
Closed

Update arg! to set Actions #3795

epage opened this issue Jun 6, 2022 · 0 comments · Fixed by #3972
Labels
A-builder Area: Builder API C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Milestone
4.0

Comments

@epage
Copy link
Member

epage commented Jun 6, 2022

Depending on circumstances, it'd be SetTrue, Set, or Append

We'll also need to find all the places where we do this manually and revert them back
@epage epage added C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change. A-builder Area: Builder API labels Jun 6, 2022
@epage epage added this to the 4.0 milestone Jun 6, 2022
epage added a commit to epage/clap that referenced this issue Jun 8, 2022
@epage
fix(parser): Deprecate args_override_self

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1428785 
This shouldn't be needed anymore now that this is effectively the new
behavior for the non-deprecated actions.

This was briefly talked about in
clap-rs#2627 but I wasn't familiar
enough with the implementation to know how safe it is.  Now, maintainrs
and users can be more confident because they are explicitly opting into
it.

See also clap-rs#3795
epage added a commit to epage/clap that referenced this issue Jul 22, 2022
@epage
fix!: Change arg! to use ArgAction

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
04cdfb9 
Fixes clap-rs#3795
@epage epage mentioned this issue Jul 22, 2022
Merged
epage added a commit to epage/clap that referenced this issue Jul 22, 2022
@epage
fix!: Change arg! to use ArgAction

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cdd3246 
Fixes clap-rs#3795
epage added a commit to epage/clap that referenced this issue Jul 22, 2022
@epage
fix!: Change arg! to use ArgAction

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
36dcb05 
Fixes clap-rs#3795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-builder Area: Builder API C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix!: Change arg! to use ArgAction epage/clap
1 participant
@epage