Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove deprecated ArgActions #3977

Merged
merged 6 commits into from Jul 23, 2022
Merged

fix!: Remove deprecated ArgActions #3977

merged 6 commits into from Jul 23, 2022

Conversation

epage
Copy link
Member

@epage epage commented Jul 23, 2022

This required changing the default

  • flags: SetTrue
  • positionals with multiple values: Append
    • So pos1 pos2 --flag pos3 doesn't cause pos3 to overwrite pos1 post2 but appends to it
  • all else: Set

To get the defaulted actions working properly, we had to move the defaulting code into Arg which required removing the non-accessible "NoAuto` settings.

@epage epage merged commit 8771f94 into clap-rs:master Jul 23, 2022
@epage epage deleted the action branch July 23, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant