fix: Misc fixes found when optimizing code size #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in clap-rs#4168
Originally, I saw the ideal as the parent command being isolated from `#[clap(flatte)]` especially after all of the doc comment leakage issues. We scaled that back to just `next_help_heading` because of the issues with settling on a policy and maintenance to cover everything. When doing `next_display_order`, we decided it would mess things up too much to isolate it. With clap-rs#1807, we instead have been moving towards setting `#[command(next_help_heading)]` anywhere, we just need to finish working out how it should work.
This dropped a fraction of a KiB but it will at least not cause people to ask if it'd help to simplify in the future.
This makes us accept `str` and not do any allocations at the cost of panicing if unsupported which I think fits our overall story in trying to catch development-time errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.