perf: Switch to &'static str by default #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overall hope is to allow a `&'static str`-only version of clap, so we need to move off of `Str` where dynamic strings are required. We need it here for subcommands due to external subcommands. This had minimal impact on code size (567.2 to 567.5 KiB)
This is a more familiar type for people and it didn't cost us anything (in fact it undid the code size change in the last commit).
This reverts commit c9d883a.
This reverts commit 429143a.
Originally, clap carried a lifetime parameter. When moving away from that, we took the approach that dynamically generated strings are always supported and `&'static str` was just an optimization. The problem is the code size increase from this is dramatic. So we're taking the opposite approach and making dynamic formatting opt-in under the `string` feature flag. When deciding on an implementation, I favored the faster one rather than the one with smaller code size since small code size can be gotten through other means. Before: 567.2 KiB, 15.975 µs After: 541.1 KiB, 9.7855 µs With `string`: 576.6 KiB, 13.016 µs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, clap carried a lifetime parameter. When moving away from
that, we took the approach that dynamically generated strings are always
supported and
&'static strwas just an optimization.The problem is the code size increase from this is dramatic. So we're
taking the opposite approach and making dynamic formatting opt-in under
the
stringfeature flag. When deciding on an implementation, Ifavored the faster one rather than the one with smaller code size since
small code size can be gotten through other means.
Before: 567.2 KiB, 15.975 µs
After: 541.1 KiB, 9.7855 µs
With
string: 576.6 KiB, 13.016 µs