Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Detector smart-agent_haproxy #406

Open
dkmatt0 opened this issue Apr 25, 2022 · 1 comment
Open

[IMPROVE] Detector smart-agent_haproxy #406

dkmatt0 opened this issue Apr 25, 2022 · 1 comment
Labels
detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors) templating About modules templating or terraform capabilities

Comments

@dkmatt0
Copy link

dkmatt0 commented Apr 25, 2022

What is the module?
https://github.com/claranet/terraform-signalfx-detectors/blob/master/modules/smart-agent_haproxy

What is the detector?
all detector in the module

Is your improvement related to a known monitoring limitations? Please describe.
Impossible to customize the command when (with a lasting_duration per example)

Describe the solution you'd like
Add variables in "when" command like this :

detect(when(signal > ${var.latency_threshold_critical}, lasting=%{if var.latency_lasting_duration_critical == null}None%{else}'${var.latency_lasting_duration_critical}'%{endif}, at_least=${var.latency_at_least_percentage_critical})).publish('CRIT')

@dkmatt0 dkmatt0 added enhancement Enhancement of existing (templating or detectors) detectors About nex or existing detectors labels Apr 25, 2022
@xp-1000 xp-1000 added detectors About nex or existing detectors templating About modules templating or terraform capabilities and removed detectors About nex or existing detectors labels Apr 25, 2022
@xp-1000
Copy link
Contributor

xp-1000 commented Apr 25, 2022

The best would be to simply use the generator to create this module.

this will fix the lasting absence but also any other lacks compared to our best practices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors) templating About modules templating or terraform capabilities
Projects
None yet
Development

No branches or pull requests

2 participants