Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Rate Limit Approach #51

Open
clarkio opened this issue Feb 8, 2019 · 3 comments
Open

Determine Rate Limit Approach #51

clarkio opened this issue Feb 8, 2019 · 3 comments
Assignees
Labels
research We need to look deeper into this topic reviews wanted Generally a Pull Request with code changes that would be helpful to have validated by others

Comments

@clarkio
Copy link
Owner

clarkio commented Feb 8, 2019

I'm opening up this issue to provide a forum for discussion on how we can best implement a way to isolate and/or prevent abuse of the chat command.

So far some suggestions I've noticed from the community are as follows:

  • limit based on time (e.g. a viewer can only highlight once every X seconds/minutes)
  • limit based on role (e.g. only mods or vips can highlight)
  • temporary ban/timeouts for abusers (e.g. no highlights for X seconds/minutes/banned)

Please feel free to add more suggestions, expand on one or share which approach seems best to you.

@DanielHe4rt
Copy link

I think the first thing u need to do is check the command spam (i did't have time to read your code yet) and set some rules to timeout and ban.
idk if this options can be setted by the user, but if not, there is a great idea

@Apidcloud
Copy link

Apidcloud commented Feb 9, 2019

You could also set a limit on the vs code client side (in addition to another one on twitch). That is, only X suggestions per minute (independent from the number of people suggesting)—sort of a funnel.
After that threshold show a notification saying that there are Y on the queue (maybe listed per viewer) where you can choose to accept or not.

That said, I think it's really important to have safety checks on both sides. Say you have 50 viewers or more and each one highlights a line. I think it's way too much, and thus suggesting doing it at vs code side too.

@clarkio clarkio self-assigned this Feb 11, 2019
@clarkio clarkio added the research We need to look deeper into this topic label Feb 11, 2019
@ConnBB
Copy link

ConnBB commented Mar 1, 2019

  • Allow mods to ban/timeout viewers.
    (-bloodconn)

@parithon parithon added the reviews wanted Generally a Pull Request with code changes that would be helpful to have validated by others label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research We need to look deeper into this topic reviews wanted Generally a Pull Request with code changes that would be helpful to have validated by others
Projects
None yet
Development

No branches or pull requests

5 participants