Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable --skip-rebase #88

Closed
wants to merge 4 commits into from
Closed

Re-enable --skip-rebase #88

wants to merge 4 commits into from

Conversation

Lenni009
Copy link

Closes #87

--skip-rebase should work again now, in theory it should block any url rebasing if present.

So this:

@import "fonts.css"

Should now become this when the flag is present:

@import url(fonts.css)

@Lenni009 Lenni009 closed this Mar 23, 2023
@jakubpawlowicz
Copy link
Collaborator

Hey @Lenni009 - any reason you went ahead with PR and then closed it?

@Lenni009
Copy link
Author

Lenni009 commented Mar 23, 2023

I wasn't really sure whether it actually fixed the issue.

Just because the flag is enabled in the CLI doesn't mean it works with the normal clean-css integration which is called.

For example if you don't give an output, the if statement modified in the PR should go to the falsy branch. But even then the URLs come out incorrectly. So just adding another way of turning that statement false doesn't fix it I believe.

I'll take a closer look at the non-CLI version today, maybe I can fix it there.

@jakubpawlowicz
Copy link
Collaborator

Thanks for writing back. I suggest starting with a failing testcase and then going down the rabbit hole. It has to be either in CLI or non-CLI codebase. Let me know if you need anything. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The behaviour of rebasing URLs when an output is given should be overwriteable
2 participants