Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh pr create newly fails if an obsolete security remote is present #5993

Closed
bk2204 opened this issue Jul 25, 2022 · 1 comment · Fixed by #5994
Closed

gh pr create newly fails if an obsolete security remote is present #5993

bk2204 opened this issue Jul 25, 2022 · 1 comment · Fixed by #5994
Labels
bug Something isn't working p2 Affects more than a few users but doesn't prevent core functions p3 Affects a small number of users or is largely cosmetic

Comments

@bk2204
Copy link

bk2204 commented Jul 25, 2022

Describe the bug

I have a remote in my repository called security, which points to an old GitHub security release remote for Git LFS. Previously, this resulted in no problems. However, now it produces the following error: GraphQL: Could not resolve to a Repository with the name 'git-lfs/git-lfs-ghsa-6rw3-3whw-jvjj'. (repo_004).

Steps to reproduce the behavior

  1. git clone https://github.com/git-lfs/git-lfs.git
  2. cd git-lfs
  3. git remote add security git@github.com:git-lfs/git-lfs-ghsa-6rw3-3whw-jvjj.git
  4. Make some changes on a branch.
  5. gh pr create -w
  6. Notice the above error.

Expected vs actual behavior

gh ignores remotes it can't resolve or doesn't understand just as before.
@bk2204 bk2204 added the bug Something isn't working label Jul 25, 2022
@cliAutomation cliAutomation added the needs-triage needs to be reviewed label Jul 25, 2022
@mislav
Copy link
Contributor

mislav commented Jul 25, 2022

Confirmed regression since v2.13.0, thank you! The desired behavior is to ignore errors about missing repos when fetching repo information in bulk; not sure why this one is surfacing.

/cc @samcoe #5614

@mislav mislav added p2 Affects more than a few users but doesn't prevent core functions p3 Affects a small number of users or is largely cosmetic and removed needs-triage needs to be reviewed labels Jul 25, 2022
@mislav mislav mentioned this issue Jul 25, 2022
Merged
@Smmfh223 Smmfh223 mentioned this issue Aug 9, 2022
Closed
@chernjie chernjie mentioned this issue Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working p2 Affects more than a few users but doesn't prevent core functions p3 Affects a small number of users or is largely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parsing base repo out of outdated git remotes cli/cli
3 participants
@mislav @bk2204 @cliAutomation