-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Desired features #5
Comments
As a specific example, it seems there's no way to specify the repo org and name to commands, nor get these from environment variables like |
@heaths Thanks for writing in, looks like I prematurely closed out cli/cli#4264 and I will reopen it. I think both issues are relevant to keep open. This one can be targeted at what features/code we want to extract from the Regarding the |
I agree |
Great idea, I added the task to #8 since it has a lot of overlap. |
@samcoe thanks for adding repository support - both getting the current or parsing a [host/]owner/repo string. As for the other ask, any problem with a PR (after |
@heaths Rather than adding that functionality to |
Seems reasonable, though would it make more sense just to have a terminal package that contains what |
I like that idea, a package that is a collection of terminal utilities that are useful and can be used together or stand alone. I would like to see a proposal of exactly what packages we would want to extract from |
Similarly, what about extracting your very nice HTTP mocking functionality? Though, perhaps that makes more sense in this module because that does seem inextricably tied to your HTTP abstractions. After using it for several PRs to the CLI now, I love it! EDIT: Opened #28 to track. |
As for a cli/go-terminal (or whatever), here's a few things that would be nice:
|
Maybe it's outside the realm of something terminal-focused - perhaps not - but you also have a lot of great Cobra Command extensions like the one I ended up copying here: https://github.com/heaths/gh-projects/blob/fad0aedddce5a5f1a49616fb694fc8c230cdd9d2/internal/cmd/flags.go |
@heaths Appreciate the proposal. Just wanted to circle back and let you know that this work made it into our roadmap https://github.com/orgs/cli/projects/3/views/1 and it is being tracked in cli/cli#5544. Also, that |
FWIW, I've been cribbing / rewriting some of the table printing functionality in heaths/gh-projects (Projects |
Kind of hard to parse through this thread but I believe we have added or decided not to add everything that was mentioned here. Going to close this out for now. I think anything that is left over can get its own dedicated issue for easier tracking. |
This looks like a great start and has good features for basic binary extensions, but when I opened cli/cli#4264 I was hoping to see more low-level implementations either ported or refactored out into a shared library both the CLI and binary extension developers could use. For example,
-R
command line switch, or at least the APIs to make adding one work. I do see that environment variables thatgh
uses are parsed, but it would be great to provide the same command line switches (even if you don't force a dependency on Cobra Command).gh
but this seems otherwise unnecessary if more of the formatting code was expose fromcli/cli/pkg
.The text was updated successfully, but these errors were encountered: