Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document coding guidelines #192

Open
bloudermilk opened this issue Mar 30, 2020 · 5 comments
Open

Document coding guidelines #192

bloudermilk opened this issue Mar 30, 2020 · 5 comments
Labels
dev Related to developing, building, depoying the site P2 Should be fixed, time and resource permitting.

Comments

@bloudermilk
Copy link
Member

  • How/when to use Tailwind, .css files, inline style
  • How/when to use comments
@loiclefloch
Copy link
Collaborator

loiclefloch commented Mar 31, 2020

@bloudermilk
Copy link
Member Author

@loiclefloch that's an excellent video! I think we should link to it from these docs. If you have time to summarize the main points that would be helpful as well :)

@loiclefloch
Copy link
Collaborator

  • maybe we could define if we want to prefer margin-top or margin-bottom to place our elements.

@bloudermilk
Copy link
Member Author

  • Understanding issue priority (P0, P1, P2, ...)
  • Don't pass pageContext into components

@bloudermilk bloudermilk added P1 Must be fixed. dev Related to developing, building, depoying the site P2 Should be fixed, time and resource permitting. and removed P1 Must be fixed. labels Apr 8, 2020
@loiclefloch
Copy link
Collaborator

  • create and use generic components
  • for margin, some people offer to not use css at all but components: https://mxstbr.com/thoughts/margin
  • run and write unit tests with jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Related to developing, building, depoying the site P2 Should be fixed, time and resource permitting.
Projects
None yet
Development

No branches or pull requests

2 participants