Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the selected sidebar link should unselect it #213

Open
bloudermilk opened this issue Apr 3, 2020 · 5 comments
Open

Clicking the selected sidebar link should unselect it #213

bloudermilk opened this issue Apr 3, 2020 · 5 comments
Labels
good first issue Good for newcomers P2 Should be fixed, time and resource permitting.

Comments

@bloudermilk
Copy link
Member

bloudermilk commented Apr 3, 2020

Context

We use the sidebar on the "Organizations" and "Capital" pages to filter down to subcategories. Both sections have an "All" view that is chosen by default when accessing the pages via the nav bar.

Screen Shot 2020-04-03 at 10 39 12 AM

Problem

Once a category or subcategory is chosen, there is no obvious way to return to the unfiltered view.

Solution

Clicking the selected category or subcategory should return to the unfiltered view.

@bloudermilk bloudermilk added good first issue Good for newcomers P1 Must be fixed. labels Apr 3, 2020
@jasonLaster jasonLaster added P2 Should be fixed, time and resource permitting. and removed P1 Must be fixed. labels Apr 3, 2020
@CodingApps
Copy link

I'd like to add a way to return to the unfiltered view with a category click.

@bloudermilk
Copy link
Member Author

@CodingApps I've partially implemented this in #200 which will ship today. There are some pieces missing though which you could take on if you'd like!

@bloudermilk
Copy link
Member Author

@CodingApps did you still want to take a stab at this?

@CodingApps
Copy link

@bloudermilk I was getting close to getting the clicked Sub-Category to unselect and clear, did you want me to complete it? I'm not sure what's remaining on #200 , some of the items listed look done.

@bloudermilk
Copy link
Member Author

bloudermilk commented Apr 14, 2020

@CodingApps only some of it got implemented! If you want to grab this you're welcome to finish it up! The only place it really got implemented was the "STAGES" sidebar filters on the capital section. This only shows when "Venture Capital" is the selected primary capital type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P2 Should be fixed, time and resource permitting.
Projects
None yet
Development

No branches or pull requests

3 participants