Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use process.getActiveResourcesInfo() instead of process._activeHandles() #418

Open
RafaelGSS opened this issue Apr 4, 2022 · 4 comments
Labels
doctor good first issue Good for newcomers

Comments

@RafaelGSS
Copy link
Contributor

nodejs/node#41587

@RafaelGSS RafaelGSS added the good first issue Good for newcomers label Apr 10, 2022
@RaisinTen
Copy link

Looking at the uses of process._activeHandles() in this repo:

it looks like the use case here is to track the number of active handles. Is that a hard requirement or will it also be okay if this tracks the number of active resources (handles + requests + timers) instead?

I'm asking because process.getActiveResourcesInfo() currently reports the names of all the active resources. Extracting the number of active handles would require users to count each handle type by name.

@RafaelGSS
Copy link
Contributor Author

I wouldn't say hard requirement, but we do have this info in the clinic doctor report, if we change it suddenly, the users will be quite confused.

@RaisinTen
Copy link

Okay, in that case, maybe a semver-major release with this change would be an acceptable solution?

@RafaelGSS
Copy link
Contributor Author

Pretty much

@RafaelGSS RafaelGSS transferred this issue from clinicjs/node-clinic-doctor Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doctor good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants