-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
so many files #82
Comments
It’s designed to generate one file per-type-per-typewriter. I think that’s a decent way to do it. How many types are you working with here? |
I was testing it on an ast for a query language so about twenty types. We use a LOT of go and have MANY other packages with MANY other types. I think it should be pretty easy to support both one file mode and one file On 18 March 2015 at 20:59, Matt Sherman notifications@github.com wrote:
|
I’m not set on it. It’s a good default, but very much a matter of taste. Some config might be a solution. Sounds like you want to mark up all your types, each of which gets its own strongly-typed walker?
|
I do not have a problem with typewriter.Type it was easy to get it work and My only problem is the number of files that are generated. On 20 March 2015 at 00:42, Matt Sherman notifications@github.com wrote:
|
Sure, will think about it. I’m sure that as others work on typewriters, they’ll want some control over that. |
any thoughts? |
The config sounds fairly simple to implement. Why don't you do it @awalterschulze and send a PR? |
If only I had the time :( |
Hi
I really like this tool.
I even wrote my own walk typewriter, that would generate the following method.
This is really useful for Abstract Syntax Trees (ast).
It is a little ugly, because of the embedded interface.
What you would actually want is:
But then everyone would have to import this type.
But lets not digress.
I now find that I just generated about 20 files each containing only this one method.
Would it be possible to have all gen code in one file or one file per typewriter or a command line option to do so?
I don't mind doing the work.
Would you be interested in such a pull request?
The text was updated successfully, but these errors were encountered: