Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting ignore for Class/forName #2316

Closed
1 task done
dotemacs opened this issue Apr 16, 2024 · 0 comments
Closed
1 task done

Linting ignore for Class/forName #2316

dotemacs opened this issue Apr 16, 2024 · 0 comments
Projects

Comments

@dotemacs
Copy link

  • I have read the Clojure etiquette and will respect it when communicating on this platform.

version

clj-kondo v2024.03.13

platform

macOS & GitHub Action CI runners, which are Linux based

editor

Not applicable

problem

The code in question:

https://github.com/dotemacs/pdfboxing/blob/8cef6ac9e47d7526e8ce18addeef2273bb392445/src/pdfboxing/common.clj#L41-L43

Returns:

$ clj-kondo --lint src
src/pdfboxing/common.clj:43:18: error: Function name must be simple symbol but got: "[B"
linting took 58ms, errors: 1, warnings: 0

repro

git clone https://github.com/dotemacs/pdfboxing
cd pdfboxing
clj-kondo --lint src

To be specific, the commit that the master is on: dotemacs/pdfboxing@8cef6ac

config

No config.edn:

$ ls -l ~/.clj-kondo/
total 0

expected behavior

With this:

(extend-protocol PDFDocument
  #_:clj-kondo/ignore
  (Class/forName "[B") ;; byte-array

I expected the error to be silenced.

@borkdude borkdude added this to Needs triage in clj-kondo via automation Apr 16, 2024
@borkdude borkdude moved this from Needs triage to Medium priority (new / enhance) in clj-kondo Apr 16, 2024
@borkdude borkdude moved this from Medium priority (new / enhance) to High priority (next release) in clj-kondo Apr 16, 2024
dotemacs added a commit to dotemacs/pdfboxing that referenced this issue Apr 18, 2024
See clj-kondo/clj-kondo#2316

But for this particluar line, just using the ignore this way, once
clj-kondo gets fixed will suffice
@borkdude borkdude moved this from High priority (next release) to In progress in clj-kondo May 16, 2024
@borkdude borkdude moved this from In progress to High priority (next release) in clj-kondo May 16, 2024
@borkdude borkdude moved this from High priority (next release) to In progress in clj-kondo May 16, 2024
clj-kondo automation moved this from In progress to Done May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
clj-kondo
  
Done
Development

No branches or pull requests

2 participants