You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although inconsequential, it's sometimes useful to have all the implementation parameter names match the definition's.
Describe the solution you'd like
When we rename a protocol's parameter declaration, all the known implementation's parameters would be renamed accordingly.
Describe alternatives you've considered
Search-and-replace would certainly work, but protocols parameters frequently have very abstract names (this, coll, el) that are frequently found in various unrelated places.
Additional context
I originally attempted to use LSP to rename a protocol's t to this in a large codebase because search-and-replace was matching various other ts (standing for timestamp)
The text was updated successfully, but these errors were encountered:
I wonder if that's the desired behavior always but maybe most of the time, what if someone wants to rename only the local var of t of that protocol and not all the implementations?
maybe we could do that and if anyone complains add a setting for the old way (although there was never a old way for protocols as we don't support rename on function arities of protocols)
I wonder if that's the desired behavior always but maybe most of the time, what if someone wants to rename only the local var of t of that protocol and not all the implementations?
The protocol declaration never has a body, so there would be no benefit to invoking a rename action vs just renaming the symbol directly!
Per ericdallo's directions
Although inconsequential, it's sometimes useful to have all the implementation parameter names match the definition's.
Describe the solution you'd like
When we rename a protocol's parameter declaration, all the known implementation's parameters would be renamed accordingly.
Describe alternatives you've considered
Search-and-replace would certainly work, but protocols parameters frequently have very abstract names (
this
,coll
,el
) that are frequently found in various unrelated places.Additional context
I originally attempted to use LSP to rename a protocol's
t
tothis
in a large codebase because search-and-replace was matching various othert
s (standing fortimestamp
)The text was updated successfully, but these errors were encountered: