Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of function, when done twice, loses track of change #1795

Open
Kaspazza opened this issue Mar 22, 2024 · 3 comments
Open

Renaming of function, when done twice, loses track of change #1795

Kaspazza opened this issue Mar 22, 2024 · 3 comments
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor

Comments

@Kaspazza
Copy link

Kaspazza commented Mar 22, 2024

Describe the bug
The problem is that when renaming the same function twice, lsp loses track of its length, making the second rename not applied or applied incorrectly (e.g. mixing name with it's parameters, renaming previous name)

To Reproduce
Steps to reproduce the behavior:

  1. Go to function-name that is used in other namespaces
  2. Execute lsp-rename and change name to a longer or shorter
  3. Save the change - everything looks good but highlighting is lost
  4. Rename the same function again, to an even shorter (or longer name)
  5. The name is messed up or the rename was not showing the proper name

Expected behavior
When I rename a function I want the name to be refreshed in all its references.
So if I rename it to a longer name, I want it in another namespace where it's referenced to be able to rename it from there again.
If I rename a function from the definition point, I want to be able to do it twice there.

Screenshots
Video recording of the issue

User details (please complete the following information):

  • OS: MacOS aarch binary
  • Editor: doom emacs
  • Version: 2024.03.17-17.22.15-nightly

Additional context
workspace-restart between renames fixes it

@Kaspazza Kaspazza added bug Something isn't working editor Related to clojure-lsp on a text editor labels Mar 22, 2024
@Kaspazza
Copy link
Author

Happens also in 2024.03.13-13.11.00

@Kaspazza
Copy link
Author

Kaspazza commented Mar 22, 2024

Happens also in 2024.03.01-11.37.51

@Kaspazza
Copy link
Author

Also in 2024.02.01-11.01.59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor Related to clojure-lsp on a text editor
Projects
None yet
Development

No branches or pull requests

1 participant