Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display fully-qualified function name on textDocument/signatureHelp #1812

Open
bigodel opened this issue May 7, 2024 · 0 comments
Open

Display fully-qualified function name on textDocument/signatureHelp #1812

bigodel opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bigodel
Copy link

bigodel commented May 7, 2024

Is your feature request related to a problem? Please describe.

The signature help should display all information pertaining to the symbol, which should include its namespace. Such a change would be trivial, since the information required is already present when constructing the labels. I'd like to also ask to remove the parenthesis around the function signature, as it breaks some heuristics for some clients to fontify the results of textDocument/signatureHelp, plus it deviates from the standard for LISP and Clojure signature (CIDER, Emacs' ElDoc, clojure-lsp's hover...).

Describe the solution you'd like

My suggestion would be to change these lines to

(defn ^:private definition->signature-informations [{:keys [arglist-strs] :as definition}]
  (map (fn [arglist-str]
         (let [qualified-name (format "%s/%s" (:ns definition) (:name definition))]
           (-> {:label (format "%s %s" qualified-name arglist-str)
                :parameters (arglist-str->parameters arglist-str)}
               (assoc-some :documentation (:doc definition)))))
       arglist-strs))
@bigodel bigodel added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant