Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize handling of strings and bytes arrays for event formatters #127

Open
jskeet opened this issue May 4, 2021 · 3 comments
Open
Assignees

Comments

@jskeet
Copy link
Contributor

jskeet commented May 4, 2021

All event formatters are expected to handle strings and byte arrays. We should make it really easy for them to do so via common code, e.g. protected methods in CloudEventFormatter.

@jskeet jskeet self-assigned this May 4, 2021
@jskeet
Copy link
Contributor Author

jskeet commented Jun 3, 2021

This hasn't been done for 2.0; I still have the Protobuf event formatter to finish though, so when that's done it will give us more data.

@bencyoung-Fignum
Copy link

Would this potentially let us inject things like https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/blob/master/src/RecyclableMemoryStream.cs into the serialization? and remove the use of Encoding.GetBytes and Encoding.GetString etc? It's hard for me to see how I could do this without cloning the current class entirely

@jskeet
Copy link
Contributor Author

jskeet commented May 5, 2023

@bencyoung-Fignum: Honestly couldn't say yet - but maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants